Summary: | JJ: workflow improvement: create a group when several layers are selected and that user clicks on "add layer" | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | gordie.lachance+dev |
Component: | Layer Stack | Assignee: | Krita Bugs <krita-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | 22shubh22, halla, lukasz.hryniuk, rishabh.chakrabarti, seoras1 |
Priority: | NOR | Keywords: | junior-jobs |
Version: | 3.1.2 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | All | ||
Latest Commit: | https://commits.kde.org/krita/3cdbd97f494bca91e80dea65fd3ef4f99dc4f38d | Version Fixed In: | |
Sentry Crash Report: | |||
Attachments: |
file changed in kis_layer_box.cpp and kis_layer_box.h
Proposed patch |
Description
gordie.lachance+dev
2017-09-25 11:49:44 UTC
Yes, this is very sensible and should be really easy to implement. Confirming, and setting to junior job. It would be perfect for a gsoc or sok student to get started on. Hi, can I take this up? Yes, sure! If you have questions, please join us on #krita on irc. (In reply to rishabh.chakrabarti from comment #2) > Hi, can I take this up? Hello, Rishabh. There hasn't been an update for a while, so I wonder how you are making progress on this. If you are busy dealing with something else, I want to take this up. Created attachment 110480 [details]
file changed in kis_layer_box.cpp and kis_layer_box.h
What's the problem with the code. please explain.
You're creating a new action every time the button is clicked, instead of triggering the action. Created attachment 111486 [details]
Proposed patch
Hi, I think I've got a working patch based on the previous patch attached by shubhamgoyal. This is my first time submitting a patch, so I'm not sure if this is the most natural way to implement the feature though.
Git commit c7ddbf1a0145d1c9a1fea01778df709c508f7c80 by Dmitry Kazakov, on behalf of Seoras Macdonald. Committed on 18/04/2018 at 08:48. Pushed by dkazakov into branch 'master'. Change the behaviour of the add layer button Summary: In the layers docker, if more than 1 layer is selected, then the add layer button now creates a quick group for the selected layers. Reviewers: #krita, rempt Reviewed By: #krita, rempt Subscribers: alvinhochun, woltherav Tags: #krita Differential Revision: https://phabricator.kde.org/D11507 M +16 -1 plugins/dockers/defaultdockers/kis_layer_box.cpp M +2 -0 plugins/dockers/defaultdockers/kis_layer_box.h https://commits.kde.org/krita/c7ddbf1a0145d1c9a1fea01778df709c508f7c80 Git commit 3cdbd97f494bca91e80dea65fd3ef4f99dc4f38d by Boudewijn Rempt, on behalf of Seoras Macdonald. Committed on 02/05/2018 at 11:54. Pushed by rempt into branch 'krita/4.0'. Change the behaviour of the add layer button Summary: In the layers docker, if more than 1 layer is selected, then the add layer button now creates a quick group for the selected layers. Reviewers: #krita, rempt Reviewed By: #krita, rempt Subscribers: alvinhochun, woltherav Tags: #krita Differential Revision: https://phabricator.kde.org/D11507 (cherry picked from commit 77d75e3d811add37b909683d61ad8e779f8524e1) M +16 -1 plugins/dockers/defaultdockers/kis_layer_box.cpp M +2 -0 plugins/dockers/defaultdockers/kis_layer_box.h https://commits.kde.org/krita/3cdbd97f494bca91e80dea65fd3ef4f99dc4f38d |