Bug 384638

Summary: Some header text labels are hardly visible, especially with Breeze dark
Product: [Applications] systemsettings Reporter: Lucas <kdeokk>
Component: sidebarviewAssignee: Marco Martin <notmart>
Severity: normal CC: anditosan1000, bugseforuns, jeffbaichina, jgrulich, kde, mail, nate, sknauss
Priority: NOR Keywords: usability
Version: 5.11.0   
Target Milestone: ---   
Platform: Neon   
OS: Linux   
Latest Commit: Version Fixed In: 5.12.2
Attachments: screenshot showing the bug

Description Lucas 2017-09-12 21:50:37 UTC
Created attachment 107825 [details]
screenshot showing the bug

Open system settings> look and feel> switch to breeze dark

Some text labels are dark on dark background. See attached screenshot (frequently used and the names of kcms)

The same bug happens in other kirigami based apps like discover. Neon dev git unstable
Comment 1 Elias Probst 2017-09-15 12:33:40 UTC
*** Bug 384730 has been marked as a duplicate of this bug. ***
Comment 2 David Edmundson 2017-10-05 11:19:26 UTC
As in, they don't change immediately, but are fine after restarting the app?
Comment 3 Elias Probst 2017-10-09 05:00:46 UTC
(In reply to David Edmundson from comment #2)
> As in, they don't change immediately, but are fine after restarting the app?

This applies in general. Has nothing to do with restarting the application.
Comment 4 Nate Graham 2017-10-22 02:08:39 UTC
*** Bug 385907 has been marked as a duplicate of this bug. ***
Comment 5 Nate Graham 2017-10-22 02:09:27 UTC
The section headers aren't very visible with a light Breeze theme, either.

In sidebar/package/contents/ui/CategoriesPage.qml, these headers are implemented as list items with the "enabled: false" property, which causes the text to become much lighter. This seems like an abuse of the system, and precludes fine-grained control of the text color. It would be better if the headers were somehow styled as actual headers, not disabled items.
Comment 6 Nate Graham 2017-11-05 02:41:35 UTC
*** Bug 386528 has been marked as a duplicate of this bug. ***
Comment 7 Nate Graham 2018-01-28 23:52:01 UTC
*** Bug 389538 has been marked as a duplicate of this bug. ***
Comment 8 Nate Graham 2018-02-18 03:20:34 UTC
I've submitted a patch that fixes this: https://phabricator.kde.org/D10620
Comment 9 Nate Graham 2018-02-19 15:06:16 UTC
Git commit 6f5b6e41ec4dec6af9693c3a22e5181ee850414b by Nathaniel Graham.
Committed on 19/02/2018 at 14:53.
Pushed by ngraham into branch 'Plasma/5.12'.

Improve sidebar header visibility

FIXED-IN: KDE Plasma 5.12.2

System Settings' sidebar headers were implemented as orginary Kirigami list items that had `enabled: false` set, which made them turn an almost unreadable light color. This a hack; it should have used real headers. And it was the wrong hack, as evidenced by the visual breakage.

This patch changes the hack to a different one that works much better. Ideally we would use real Kirigami list headers here, but the current system settings implementation seems to make this a challenge and I'm not sure it's worth it. Willing to be proven wrong, though.

Test Plan:
Before, primary category headers, Breeze light:

After, primary category headers, Breeze light:

Before, sub-category headers, Breeze light:

After, sub-category headers, Breeze light:

Before, primary category headers, Breeze dark:

After, primary category headers, Breeze dark:

Before, sub-category headers, Breeze dark:

After, sub-category headers, Breeze dark:

Reviewers: #plasma, #kirigami, mart

Reviewed By: #plasma, #kirigami, mart

Subscribers: rkflx, plasma-devel

Tags: #plasma, #kirigami

Differential Revision: https://phabricator.kde.org/D10620

M  +1    -1    sidebar/package/contents/ui/CategoriesPage.qml
M  +0    -1    sidebar/package/contents/ui/SubCategoryPage.qml