Bug 384427

Summary:	core/libs/dngwriter/extra/dng_sdk/dng_xmp.cpp: int / long mixup ?
Product:	[Applications] digikam	Reporter:	dcb314
Component:	Plugin-Bqm-DngConverter	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles
Priority:	NOR
Version First Reported In:	5.7.0
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:	7.3.0
Sentry Crash Report:

Description dcb314 2017-09-06 11:41:32 UTC

[digikam-5.7.0/core/libs/dngwriter/extra/dng_sdk/dng_xmp.cpp:269]: (warning) %u 
in format string (no. 1) requires 'unsigned int' but the argument type is 'unsig
ned long'.
[digikam-5.7.0/core/libs/dngwriter/extra/dng_sdk/dng_xmp.cpp:304]: (warning) %u 
in format string (no. 1) requires 'unsigned int' but the argument type is 'unsig
ned long'.
[digikam-5.7.0/core/libs/dngwriter/extra/dng_sdk/dng_xmp.cpp:3584]: (warning) %u
 in format string (no. 1) requires 'unsigned int' but the argument type is 'unsi
gned long'.
[digikam-5.7.0/core/libs/dngwriter/extra/dng_sdk/dng_xmp.cpp:269]: (warning) %u 
in format string (no. 2) requires 'unsigned int' but the argument type is 'unsig
ned long'.
[digikam-5.7.0/core/libs/dngwriter/extra/dng_sdk/dng_xmp.cpp:269]: (warning) %u 
in format string (no. 3) requires 'unsigned int' but the argument type is 'unsig
ned long'.

In general, it is unwise to assume that ints and longs are the same size,
unless this code is for a specific platform & compiler.

Comment 1 caulier.gilles 2017-09-11 09:14:44 UTC

We will not touch this Adobe DNG SDK source code. It's must be updated in the future.

Gilles Caulier

Comment 2 caulier.gilles 2021-05-10 20:46:07 UTC

Fixed in 7.3.0 with DNG SDK updated to 1.5