Bug 384423

Summary: core/libs/dngwriter/extra/dng_sdk/dng_string.cpp:2027: confused logic ?
Product: [Applications] digikam Reporter: dcb314
Component: Plugin-Bqm-DngConverterAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles
Priority: NOR    
Version First Reported In: 5.7.0   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: 7.3.0
Sentry Crash Report:

Description dcb314 2017-09-06 11:22:20 UTC
digikam-5.7.0/core/libs/dngwriter/extra/dng_sdk/dng_string.cpp:2027]: (style) Expression is always false because 'else if' condition matches previous condition at line 2022.

Source code is

               if (b > a)
                    {
                    return 1;
                    }

                else if (a < b)
                    {
                    return -1;
                    }
Comment 1 caulier.gilles 2017-09-06 18:15:07 UTC
This code come from Adobe DNG SDK.

It's fabulous to see how Adobe code this king of tests...

We don't know how to fix it. We don't write this code. So We must ignore.

Note : in all cases, DNG SDK will be updated as well when Adobe will release a new version.

Gilles Caulier
Comment 2 caulier.gilles 2021-05-10 20:42:32 UTC
Fixed in 7.3.0 with DNG SDK updated to 1.5