Bug 384422

Summary:	core/libs/dngwriter/extra/dng_sdk/dng_mosaic_info.cpp:637: bad if ?
Product:	[Applications] digikam	Reporter:	dcb314
Component:	Plugin-Bqm-DngConverter	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles
Priority:	NOR
Version First Reported In:	5.7.0
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:	7.3.0
Sentry Crash Report:

Description dcb314 2017-09-06 11:16:31 UTC

[digikam-5.7.0/core/libs/dngwriter/extra/dng_sdk/dng_mosaic_info.cpp:637]: (style) Same expression on both sides of '&&'.

Source code is

  if (mapN && mapS && mapW && mapW)

Maybe better code

  if (mapN && mapS && mapW && mapE)

Comment 1 caulier.gilles 2017-09-11 09:15:20 UTC

We will not touch this Adobe DNG SDK source code. It's must be updated in the future.

Gilles Caulier

Comment 2 caulier.gilles 2021-05-10 20:42:02 UTC

Fixed in 7.3.0 with DNG SDK updated to 1.5