Bug 384421

Summary: Bad if condition in source code
Product: [Applications] digikam Reporter: dcb314
Component: Portability-CompilationAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED INTENTIONAL    
Severity: normal CC: caulier.gilles
Priority: NOR    
Version First Reported In: 5.7.0   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: 7.5.0
Sentry Crash Report:

Description dcb314 2017-09-06 11:13:47 UTC
[digikam-5.7.0/core/libs/dimg/filters/greycstoration/cimg/CImg.h:8792]: (warning) Opposite inner 'if' condition leads to a dead code block.

Source code is

      if (!is_closed && !is_fullscreen) {
        if (is_fullscreen) _desinit_fullscreen();
Comment 1 caulier.gilles 2017-09-06 16:22:39 UTC
This one can be dropped.

CImg is less an less used in digiKam, and code relevant of this file is never used in fact.

Gilles Caulier