| Summary: | There are two actions (Bold, Add Bookmark) that want to use the same shortcut (Ctrl+B) | ||
|---|---|---|---|
| Product: | [Unmaintained] kjots | Reporter: | Scarlett Moore <sgmoore> |
| Component: | general | Assignee: | Stephen Kelly <steveire> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | carlen.cagle, c_pan, grymas, jhnpldng01, profcor2 |
| Priority: | NOR | Keywords: | junior-jobs |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kjots/ca6f4b963e83ed91cc7314e1b60fe6607b61b53e | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | Shutter Software Screen Capture of KJots Warning Message | ||
|
Description
Scarlett Moore
2017-08-25 09:54:09 UTC
I get the same. Tried to change bookmark to Ctrl+D but that's reserved for New Book *** Bug 389489 has been marked as a duplicate of this bug. *** Immediately after software launch the following KJots message appears on screen (copied directly from message screen/text): There are two actions (Bold, Add Bookmark) that want to use the same shortcut (Ctrl+B). This is most probably a bug. Please report it in bugs.kde.org Created attachment 118022 [details]
Shutter Software Screen Capture of KJots Warning Message
Immediately after software launch the following KJots message appears on screen (copied directly from message screen/text):
There are two actions (Bold, Add Bookmark) that want to use the same shortcut (Ctrl+B). This is most probably a bug. Please report it in bugs.kde.org
Immediately after software launch the following KJots message appears on screen (copied directly from message screen/text): There are two actions (Bold, Add Bookmark) that want to use the same shortcut (Ctrl+B). This is most probably a bug. Please report it in bugs.kde.org Git commit ca6f4b963e83ed91cc7314e1b60fe6607b61b53e by Igor Poboiko.
Committed on 18/04/2020 at 22:06.
Pushed by poboiko into branch 'master'.
[KJots] Fix bookmarks actions
Summary:
This patch ports KJots from deprecated `KBookmarksMenu` API (see {D25660}).
On my machine, it also fixes a crash (`bm_action` was null for some reason,
I did not investigate it though).
It also fixes the shortcuts collision (`action->setShortcut` was not enough,
one also needs to run `actionCollection->setDefaultShortcut`).
Test Plan:
1) Start KJots
2) It don't crash, and `Ambiguous shortcuts` dialog does not appear)
3) Open `Bookmarks` menu, the shortcut is `Ctrl+Shift+B`.
Reviewers: dvratil
Reviewed By: dvratil
Subscribers: winterz, kde-pim
Tags: #kde_pim
Differential Revision: https://phabricator.kde.org/D28775
M +8 -5 src/kjotswidget.cpp
https://commits.kde.org/kjots/ca6f4b963e83ed91cc7314e1b60fe6607b61b53e
*** Bug 401212 has been marked as a duplicate of this bug. *** *** Bug 420974 has been marked as a duplicate of this bug. *** |