| Summary: | placesitem.cpp typo in PlacesItem::updateBookmarkForRole("udi") | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Chris Holland <zrenfire> |
| Component: | panels: places | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/dolphin/24baf24f5fe089302850c7844f1ecdfd60fbb0f1 | Version Fixed In: | |
Git commit 24baf24f5fe089302850c7844f1ecdfd60fbb0f1 by Christoph Feck. Committed on 23/08/2017 at 10:53. Pushed by cfeck into branch 'master'. Fix typo in udi string Spotted by Chris Holland. M +1 -1 src/panels/places/placesitem.cpp https://commits.kde.org/dolphin/24baf24f5fe089302850c7844f1ecdfd60fbb0f1 |
While skimming this code I noticed "udi)" had an extra ). I assume that's a typo making PlacesItem::updateBookmarkForRole("udi") do nothing. https://github.com/KDE/dolphin/blame/f38960e034cf622bc87575e91014404e8128f120/src/panels/places/placesitem.cpp#L319 I've no idea under what conditions udi would change and if there's any reported bugs it might affect.