| Summary: | LockScreenUi.qml uses easing and not easing.type on line 98 | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | David Greengas <dave.greengas> |
| Component: | Global Theme packages | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kde, plasma-bugs, simonandric5 |
| Priority: | NOR | ||
| Version: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/plasma-workspace/1511e486ae46789a34506461f2847d4a37f605cc | Version Fixed In: | |
| Attachments: | Proposed Patch | ||
Yes a patch would be great. It's in plasma-workspace git repository. For uploading diffs, please follow: https://community.kde.org/Infrastructure/Phabricator Message if you get stuck or visit #plasma on Freenode. Created attachment 106930 [details]
Proposed Patch
Git commit 1511e486ae46789a34506461f2847d4a37f605cc by David Edmundson, on behalf of David Greengas. Committed on 29/07/2017 at 14:39. Pushed by davidedmundson into branch 'Plasma/5.10'. Use correct easing type values Summary: Per the QML specification, the animation Easing.InQuad should be specified with easing.type, not easing. Test Plan: run kscreenlocker --testing The console output should not display a warning about the animation. Reviewers: davidedmundson Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D6970 M +1 -1 lookandfeel/contents/lockscreen/LockScreenUi.qml https://commits.kde.org/plasma-workspace/1511e486ae46789a34506461f2847d4a37f605cc |
I was trying to test an issue with the lockscreen wallpaper and I was using the kscreenlocker_greet --testing to test the lock screen. On the console output I noticed the line "Unable to assign int to QEasingCurve." After searching online, I noticed that the field easing should be easing.type on line 98 of root/lookandfeel/contents/lockscreen/LockScreenUi.qml of the plasma-workspace project. I changed it from: PropertyAnimation { id: stateChangeAnimation; properties: "y"; duration: 300; easing: Easing.InQuad} to: PropertyAnimation { id: stateChangeAnimation; properties: "y"; duration: 300; easing.type: Easing.InQuad} The error went away and I actually saw an animation. I did not see a placeholder for plasma-workspace in the bug report. Let me know if you need me to create a diff for this. I also saw this as part of org.kde.breeze.desktop package in my plasma/look-and-feel directory. I am guessing that this is the origin of this file.