| Summary: | KSysGuard tabs do not render ampersand (&) in their title | ||
|---|---|---|---|
| Product: | [Applications] ksysguard | Reporter: | Flávio Monteiro <flaviomonteiro2013> |
| Component: | ksysguardd | Assignee: | KSysGuard Developers <ksysguard-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | carlavilla, nate, tino.135 |
| Priority: | NOR | Keywords: | junior-jobs, reproducible |
| Version: | 5.9.4 | ||
| Target Milestone: | --- | ||
| Platform: | Kubuntu | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=319100 | ||
| Latest Commit: | https://commits.kde.org/ksysguard/2a95e337cfd4a0c0943bee653b6e446c2ce1d32c | Version Fixed In: | |
| Attachments: |
Image of the bug
Patch to solve the problem with the single & |
||
This is a Qt feature : if you have an ampersand in a tab title it is used to make an "alt" shortcut with the following character (&a -> alt+a) and the ampersand won't be displayed. If you double the ampersand (&&) it will just output the character (no shortcut). I proposed a fix that automatically double the ampersands Created attachment 110098 [details]
Patch to solve the problem with the single &
Git commit 5ce56e6bb5ef7efc7139f171951f7124adf4d56a by Nathaniel Graham, on behalf of Sergio Carlavilla. Committed on 03/02/2018 at 18:58. Pushed by ngraham into branch 'master'. Correction with the & problem in tabs Summary: KSysGuard does not render the ampersand character in tab titles Test Plan: Tested on Arch Linux with Plasma 5.11.5 and Qt 5.10 I added a tab with an & in the title and I checked that the & displays correctly. I added a tab with two and more & and I checked that all the & displays correctly. Also works when open a saved tab. Reviewers: mlaurent, ngraham Reviewed By: ngraham Subscribers: ngraham, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D10151 M +2 -2 gui/Workspace.cpp https://commits.kde.org/ksysguard/5ce56e6bb5ef7efc7139f171951f7124adf4d56a Git commit 0ed4aae225c0dd67a0ae86b8e5ffdaf574ac16a6 by Nathaniel Graham, on behalf of Sergio Carlavilla. Committed on 03/02/2018 at 19:05. Pushed by ngraham into branch 'Plasma/5.8'. Correction with the & problem in tabs Summary: KSysGuard does not render the ampersand character in tab titles Test Plan: Tested on Arch Linux with Plasma 5.11.5 and Qt 5.10 I added a tab with an & in the title and I checked that the & displays correctly. I added a tab with two and more & and I checked that all the & displays correctly. Also works when open a saved tab. Reviewers: mlaurent, ngraham Reviewed By: ngraham Subscribers: ngraham, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D10151 M +2 -2 gui/Workspace.cpp https://commits.kde.org/ksysguard/0ed4aae225c0dd67a0ae86b8e5ffdaf574ac16a6 Git commit 2a95e337cfd4a0c0943bee653b6e446c2ce1d32c by Nathaniel Graham, on behalf of Sergio Carlavilla. Committed on 03/02/2018 at 19:05. Pushed by ngraham into branch 'Plasma/5.12'. Correction with the & problem in tabs Summary: KSysGuard does not render the ampersand character in tab titles Test Plan: Tested on Arch Linux with Plasma 5.11.5 and Qt 5.10 I added a tab with an & in the title and I checked that the & displays correctly. I added a tab with two and more & and I checked that all the & displays correctly. Also works when open a saved tab. Reviewers: mlaurent, ngraham Reviewed By: ngraham Subscribers: ngraham, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D10151 M +2 -2 gui/Workspace.cpp https://commits.kde.org/ksysguard/2a95e337cfd4a0c0943bee653b6e446c2ce1d32c |
Created attachment 106735 [details] Image of the bug KSysGuard does not render the ampersand character in tab titles. Please see the attachment.