Bug 382459

I don't think these are different issues. This probably has to be fixed somewhere in ECM  (same thing for bug 382460)

(In reply to Christophe Giboudeaux from comment #1)
> I don't think these are different issues. This probably has to be fixed
> somewhere in ECM  (same thing for bug 382460)

In kio the Exec line needs to be changed to something like

Exec=@NEW_VARIABLE_FOR CROSS_PLATTFORM_LIBEXEC_PATH@kiod5

ECM is responsible to setup these variable according to related platform e.g.

if(WIN32)
    set(NEW_VARIABLE_FOR CROSS_PLATTFORM_LIBEXEC_PATH)
else()
    set(NEW_VARIABLE_FOR CROSS_PLATTFORM_LIBEXEC_PATH ${KDE_INSTALL_FULL_LIBEXECDIR}/kf5/)
endif()

https://cgit.kde.org/extra-cmake-modules.git/tree/kde-modules/KDEInstallDirs.cmake#n31 states

# ``LIBEXECDIR``
#     executables for internal use by programs and libraries (``BINDIR`` on
#     Windows, ``LIBDIR/libexec`` otherwise) [``LIBEXEC_INSTALL_DIR``]

and at https://cgit.kde.org/extra-cmake-modules.git/tree/kde-modules/KDEInstallDirs.cmake#n440 there is defined LIBEXECDIR_KF5 

which indicates that the ECM part has been done and that LIBEXECDIR_KF5 need to be used inside kio.

(In reply to Ralf Habacker from comment #3)
> https://cgit.kde.org/extra-cmake-modules.git/tree/kde-modules/KDEInstallDirs.
> cmake#n440 there is used

_define_non_cache(LIBEXECDIR_KF5 "${CMAKE_INSTALL_LIBEXECDIR}/kf5")

which is defined at https://cgit.kde.org/extra-cmake-modules.git/tree/kde-modules/KDEInstallDirs.cmake#n387 which indicates that for kf5 libexec also KDE_INSTALL_FULL_LIBEXECDIR_KF5 could be used on non windows. On windows this variable could not be used because it would have a non empty prefix; instead an empty string or KDE_INSTALL_LIBEXECDIR_KF5 (which should also be empty) should work

The conclusion is that in the services something like the following should be used

Exec=@NEW_VARIABLE_FOR CROSS_PLATTFORM_LIBEXEC_PATH@kiod5

and in the top level CMakeLists.txt something like 

if(WIN32)
    set(NEW_VARIABLE_FOR CROSS_PLATTFORM_LIBEXEC_KF5_PATH )
else()
    set(NEW_VARIABLE_FOR CROSS_PLATTFORM_LIBEXEC__KF5_PATH ${KDE_INSTALL_FULL_LIBEXECDIR_KF5})
endif()

or

if(WIN32)
    set(NEW_VARIABLE_FOR CROSS_PLATTFORM_LIBEXEC_KF5_PATH ${KDE_INSTALL_LIBEXECDIR_KF5})
else()
    set(NEW_VARIABLE_FOR CROSS_PLATTFORM_LIBEXEC__KF5_PATH ${KDE_INSTALL_FULL_LIBEXECDIR_KF5})
endif()




Exec=@SOME_PREFIX@kiod5

@something@somedir without any separator is not intuitive. I'd really prefer having something to replace the configure_file macro instead.

(In reply to Christophe Giboudeaux from comment #5)
> @something@somedir without any separator is not intuitive. I'd really prefer
> having something to replace the configure_file macro instead.

You are thinking about something like https://build.opensuse.org/package/view_file/home:rhabacker:branches:windows:mingw:win32:KF536/mingw32-kwallet/0002-Win32-fix-for-installing-kwalletd-dbus-service.patch?expand=1 ?

review request https://phabricator.kde.org/D9383

Git commit 105cdd8fb3c433588f799c901dd32ceb99b2cf11 by Ralf Habacker.
Committed on 07/01/2018 at 18:15.
Pushed by habacker into branch 'master'.

Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file

Summary:
Related: bug 388059, bug 388060, bug 388062, bug 388063
FIXED-IN:5.43.0

Test Plan:
compiled against installed HEAD of kdbusaddons git master branch and inspected generated service files;
On Windows only the executable is used, which is expected

Reviewers: dfaure, kfunk, bcooksley

Reviewed By: dfaure

Subscribers: #frameworks

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D9669

M  +1    -2    src/ioslaves/http/kcookiejar/CMakeLists.txt
D  +0    -4    src/ioslaves/http/kcookiejar/org.kde.kcookiejar5.service.in
M  +1    -4    src/kiod/CMakeLists.txt
D  +0    -4    src/kiod/org.kde.kiod5.service.in
M  +1    -2    src/kioexec/CMakeLists.txt
D  +0    -3    src/kioexec/org.kde.kioexecd.service.in
M  +1    -2    src/kpasswdserver/CMakeLists.txt
D  +0    -4    src/kpasswdserver/org.kde.kpasswdserver.service.in
M  +1    -2    src/kssld/CMakeLists.txt
D  +0    -4    src/kssld/org.kde.kssld5.service.in

https://commits.kde.org/kio/105cdd8fb3c433588f799c901dd32ceb99b2cf11