|
Description
Christopher Tanner
2017-07-11 15:51:36 UTC
Created attachment 106591 [details]
Demo file to duplicate the problem on master
Using this demo file run a Transaction-Report by Category. It shows 1000 in both income categories but not amounts of the splits (which sum up to 1000). This used to work in the 4.8 branch (and still might - I have not tested it). Maybe someone can check this on a recent 4.8 version.
Git commit 467f0cc2d07104d4770868c8b8b3b6d16345700d by Łukasz Wojniłowicz. Committed on 13/07/2017 at 17:43. Pushed by wojnilowicz into branch 'master'. Show correct totals for Transactions by Category FIXED-IN:5.0 Signed-off-by: Łukasz Wojniłowicz <lukasz.wojnilowicz@gmail.com> M +9 -1 kmymoney/reports/querytable.cpp https://commits.kde.org/kmymoney/467f0cc2d07104d4770868c8b8b3b6d16345700d That fixed the problem. Thanks Chris (In reply to Christopher Tanner from comment #3) > That fixed the problem. Thanks > > Chris No problem. Please report if something is not working as before. It's very needed. The best way is just like Thomas did it i.e. with .kmy test file attached. Łukasz Created attachment 106608 [details] Report screenshot from recent 4.8 (In reply to Thomas Baumgart from comment #1) > This used to work in the 4.8 branch (and still might - I have not tested > it). Maybe someone can check this on a recent 4.8 version. Screenshot from 4.8 has been appended *** Bug 380194 has been marked as a duplicate of this bug. *** (In reply to NSLW from comment #2) ... > Show correct totals for Transactions by Category > FIXED-IN:5.0 > Signed-off-by: Łukasz Wojniłowicz <lukasz.wojnilowicz@gmail.com> > > M +9 -1 kmymoney/reports/querytable.cpp > > https://commits.kde.org/kmymoney/467f0cc2d07104d4770868c8b8b3b6d16345700d This commit breaks the display with multiple currencies, as reported with bug 448788. Created attachment 173254 [details]
Screenshot of the associated report with currency conversion and the initial problem
Created attachment 173255 [details]
Screenshot of the associated report without currency conversion and the initial problem
Created attachment 173256 [details]
Updated demo file including the associated reports
Created attachment 173257 [details]
Updated demo file including multi currency account and the associated reports
Created attachment 173258 [details]
Screenshot of the associated report with currency conversion and incorrect patch applied
Created attachment 173259 [details]
Screenshot of the associated report without currency conversion and incorrect patch applied
Created attachment 173260 [details]
Screenshot of the associated report with currency conversion and the initial problem
Created attachment 173261 [details]
Screenshot of the associated report without currency conversion and the initial problem
Created attachment 173262 [details]
Screenshot of the associated report without currency conversion (Version 4)
Created attachment 173263 [details]
Screenshot of the associated report with currency conversion (Version 4)
(In reply to Ralf Habacker from comment #13) > Created attachment 173259 [details] > Screenshot of the associated report without currency conversion and incorrect patch applied https://bugs.kde.org/attachment.cgi?id=173259 Apart from the fact that using the same VAT account (EUR) for the transaction in FRF might be wrong, this report seems correct to me. (In reply to Ralf Habacker from comment #12) > Created attachment 173258 [details] > Screenshot of the associated report with currency conversion and incorrect patch applied This reports looks incorrect to me. It should be like this. (In reply to Ralf Habacker from comment #17) > Created attachment 173263 [details] > Screenshot of the associated report with currency conversion (Version 4) A possibly relevant merge request was started @ https://invent.kde.org/office/kmymoney/-/merge_requests/232 Git commit fd13f447e138b4f3fee690edf36e7566173e4c36 by Ralf Habacker. Committed on 26/09/2024 at 19:01. Pushed by habacker into branch 'master'. Add note that report results may be incorrect This note can be removed once the cause of the discrepancies has been resolved or limited to specific reports once the causes have been narrowed down. M +4 -0 kmymoney/plugins/views/reports/core/pivottable.cpp M +5 -0 kmymoney/plugins/views/reports/core/querytable.cpp M +10 -0 kmymoney/plugins/views/reports/core/reporttable.cpp M +5 -0 kmymoney/plugins/views/reports/core/reporttable.h https://invent.kde.org/office/kmymoney/-/commit/fd13f447e138b4f3fee690edf36e7566173e4c36 The issue is also present in the actual git master branch. Git commit b4f6901f8b685e88d9f6423e7043ede26c9ea382 by Ralf Habacker. Committed on 30/10/2024 at 13:36. Pushed by habacker into branch 'master'. Add test case for bug 382245 M +1 -0 kmymoney/plugins/views/reports/core/tests/data/CMakeLists.txt A +20 -0 kmymoney/plugins/views/reports/core/tests/data/test-382245-report-querytable-Buchungen-nach-Kategorie-_mit-Umrechnung_.csv A +22 -0 kmymoney/plugins/views/reports/core/tests/data/test-382245-report-querytable-Buchungen-nach-Kategorie-_ohne-Umrechnung_.csv A +209 -0 kmymoney/plugins/views/reports/core/tests/data/test-382245.xml https://invent.kde.org/office/kmymoney/-/commit/b4f6901f8b685e88d9f6423e7043ede26c9ea382 Git commit a346d765a181c6a080102d4c2308dad36f93daa0 by Ralf Habacker. Committed on 30/10/2024 at 14:14. Pushed by habacker into branch 'master'. Revert "Add note that report results may be incorrect" As the related issue has been fixed, this message is now obsolate and can be removed. This reverts commit fd13f447e138b4f3fee690edf36e7566173e4c36. M +0 -4 kmymoney/plugins/views/reports/core/pivottable.cpp M +0 -5 kmymoney/plugins/views/reports/core/querytable.cpp M +0 -10 kmymoney/plugins/views/reports/core/reporttable.cpp M +0 -5 kmymoney/plugins/views/reports/core/reporttable.h https://invent.kde.org/office/kmymoney/-/commit/a346d765a181c6a080102d4c2308dad36f93daa0 Git commit eec2645f3a5623a32390d209169c780a8c5c653e by Ralf Habacker. Committed on 30/10/2024 at 14:14. Pushed by habacker into branch 'master'. Fix conversion to base currency for reports containing categories The previously used logic to recognize the conversion to the base currency was not correct for the report mentioned in this error. It was added to fix bug 448788 and worked there because the base currency was taken from the first split, which happened to be the same as the one from the file. In general, when converting to the base currency, the base currency of the file should be used and not the currency from the first split, which has been corrected with this commit. Related: bug 448788 FIXED-IN:5.2.0 M +2 -2 kmymoney/plugins/views/reports/core/querytable.cpp https://invent.kde.org/office/kmymoney/-/commit/eec2645f3a5623a32390d209169c780a8c5c653e |