Bug 382065

Summary: Weird behavior with smudge brushes and selection
Product: [Applications] krita Reporter: radian <xenys25>
Component: Brush enginesAssignee: Dmitry Kazakov <dimula73>
Status: RESOLVED FIXED    
Severity: normal CC: dimula73, halla
Priority: NOR    
Version First Reported In: 4.0 pre-alpha   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: smudge bugs

Description radian 2017-07-06 16:12:38 UTC
Created attachment 106465 [details]
smudge bugs

There is 2 bugs new in 4.0, happens with smudge brushes + selection:

1) brush samples square around brush tip instead of form of brush tip

2) brush can paint outside of selection

See attachment (pressure didn't work while I recorded it but effect is very visible).
Comment 1 Halla Rempt 2017-11-23 10:02:33 UTC
I can confirm the issue. it was already present in the first development build, too.
Comment 2 Halla Rempt 2017-11-28 14:26:14 UTC
*** Bug 387399 has been marked as a duplicate of this bug. ***
Comment 3 Dmitry Kazakov 2018-01-05 08:44:32 UTC
The selection problem happens because the new Alpha color space doesn't support Multiply blending mode.
Comment 4 Dmitry Kazakov 2018-01-05 08:57:20 UTC
Git commit 1a648228608cc37b469c80ca8a6b8011bac6c7dc by Dmitry Kazakov.
Committed on 05/01/2018 at 08:56.
Pushed by dkazakov into branch 'master'.

Implement Multiply blending mode for alpha color space

It fixes using selection in the colorsmudge brush :)

M  +36   -1    libs/pigment/colorspaces/KoAlphaColorSpace.cpp

https://commits.kde.org/krita/1a648228608cc37b469c80ca8a6b8011bac6c7dc