Bug 381676

Summary: Wrong icons on Unselect all and Select group buttons
Product: [Applications] krusader Reporter: Roman <freeslave93>
Component: generalAssignee: Krusader Bugs Distribution List <krusader-bugs-null>
Status: RESOLVED DUPLICATE    
Severity: normal CC: alex.bikadorov, krusader-bugs-null, kubry
Priority: NOR    
Version: 2.6.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: Wrong icons on Select group and Unselect all buttons

Description Roman 2017-06-26 11:29:21 UTC
Created attachment 106305 [details]
Wrong icons on Select group and Unselect all buttons

See attachment. It uses some cursor icon instead.
Also kr_unselect.png is presented in krusader files. Not sure where icon for select group should be taken from.
Krusader 2.6.0 compiled from sources on Debian stretch.
Comment 1 Ganton 2017-07-06 08:33:44 UTC
Perhaps this is related to
https://bugs.kde.org/show_bug.cgi?id=372964 , which has a 
similar screenshot (https://bugsfiles.kde.org/attachment.cgi?id=102453).
Comment 2 Alex Bikadorov 2017-07-06 18:24:13 UTC
Yes, duplicate. More discussion about the never ending icon problem: Bug 372966

*** This bug has been marked as a duplicate of bug 372964 ***
Comment 3 Nikita Melnichenko 2018-04-22 22:03:40 UTC
Git commit 94ea5b69af14620abd4a44a13240ca9b2749641b by Nikita Melnichenko.
Committed on 22/04/2018 at 22:00.
Pushed by melnichenko into branch 'master'.

Refactored and unified icon rendering, implemented per-icon fallback logic

Merge branch 'fix-missing-icons'

The merged branch contains implementation of per-icon fallback logic:
1. Search icon in the active icon theme — if found, use it.
2. Search it in the icon theme that is specified in Krusader config — if found, use it.
3. Search it in Breeze or Oxygen (in case any of these installed) — if found, use it.
4. Otherwise use a default "icon-missing" icon bundled with Krusader.

FIXED: [ 372964 ] At least one Oxygen icon in Krusader is not correctly seen (using Kubuntu 16.04)
Related: bug 372964, bug 372966, bug 376699, bug 386554, bug 388691, bug 391899

FIXED: [ 372966 ] Some icons are not seen using a plain Ubuntu (not Kubuntu) 16.04

Differential Revision: https://phabricator.kde.org/D10352

M  +11   -10   krusader/kractions.cpp
M  +2    -8    krusader/krusader.cpp

https://commits.kde.org/krusader/94ea5b69af14620abd4a44a13240ca9b2749641b