| Summary: | Add filename preview to Preferences window | ||
|---|---|---|---|
| Product: | [Applications] Spectacle | Reporter: | KDE Neon user <emailmeat> |
| Component: | General | Assignee: | Boudhayan Gupta <me> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | nate, null |
| Priority: | NOR | Keywords: | junior-jobs |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=390856 | ||
| Latest Commit: | https://commits.kde.org/spectacle/4602c0efc01f7728c196d7a5c98c30fe23ae3009 | Version Fixed In: | 19.08.0 |
| Sentry Crash Report: | |||
|
Description
KDE Neon user
2017-06-14 02:02:56 UTC
This is done quite nicely in Gwenview's importer (type "gwenview_importer .", click on "Settings"). Perhaps it could be reused from there? Note: Replicating Gwenview's click-to-input placeholders in Spectacle is tracked in Bug 390856. Git commit 37448f5c48ee0d8799c3dda6dbe5fc1e3fe41147 by Nate Graham, on behalf of David Redondo.
Committed on 18/03/2019 at 09:13.
Pushed by ngraham into branch 'master'.
Show preview of the filename in the save settings
Summary:
Shows the a preview of the configured filename template on the save settings page. I'm not sure about the placement of the label but the functionality should be there. This also again includes a small refactor to access the placeholder replacement from outside of the ExportManager.
Test Plan: {F6697579}
Reviewers: #spectacle, #vdg, ngraham
Reviewed By: #spectacle, #vdg, ngraham
Subscribers: meven, ngraham, broulik
Tags: #spectacle
Differential Revision: https://phabricator.kde.org/D19775
M +6 -1 src/ExportManager.cpp
M +1 -0 src/ExportManager.h
M +26 -6 src/Gui/SettingsDialog/SaveOptionsPage.cpp
M +4 -0 src/Gui/SettingsDialog/SaveOptionsPage.h
https://commits.kde.org/spectacle/37448f5c48ee0d8799c3dda6dbe5fc1e3fe41147
Git commit 4602c0efc01f7728c196d7a5c98c30fe23ae3009 by Nate Graham, on behalf of David Redondo.
Committed on 21/03/2019 at 23:15.
Pushed by ngraham into branch 'Applications/19.04'.
Show preview of the filename in the save settings
Summary:
Shows the a preview of the configured filename template on the save settings page. I'm not sure about the placement of the label but the functionality should be there. This also again includes a small refactor to access the placeholder replacement from outside of the ExportManager.
Test Plan: {F6697579}
Reviewers: #spectacle, #vdg, ngraham
Reviewed By: #spectacle, #vdg, ngraham
Subscribers: meven, ngraham, broulik
Tags: #spectacle
Differential Revision: https://phabricator.kde.org/D19775
M +6 -1 src/ExportManager.cpp
M +1 -0 src/ExportManager.h
M +26 -6 src/Gui/SettingsDialog/SaveOptionsPage.cpp
M +4 -0 src/Gui/SettingsDialog/SaveOptionsPage.h
https://commits.kde.org/spectacle/4602c0efc01f7728c196d7a5c98c30fe23ae3009
|