| Summary: | Show on Updates page which updates are security-related | ||
|---|---|---|---|
| Product: | [Applications] Discover | Reporter: | andreas <kainz.a> |
| Component: | discover | Assignee: | Dan Leinir Turthra Jensen <leinir> |
| Status: | CONFIRMED --- | ||
| Severity: | wishlist | CC: | aleixpol, nate, shai, yvan |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
andreas
2017-06-13 21:22:10 UTC
Are you sure this is the case? Because it should be showing the right icon (see QString DiscoverNotifier::iconName() const) What makes you think it's not done properly? the plasmoid did show the right icon but I miss the security information in the discover updater. which packages need an security issues update? How does that make a difference? Will you choose not to update depending on which packages need update? This is especially interesting for users of rolling releases. Sometimes I delay applying updates for several months (instead of updating nearly daily) to minize wear-out SSD drive, but should apply security updates as soon as they are available. @Christoph, so the plasmoid does show a different icon, andreas's complaint is that once you open Discover on update mode, you don't get to see which one it is. Git commit 0c1c5a16a7d6a52d6026b84ef094a2f2f258d2ab by Aleix Pol. Committed on 08/01/2018 at 17:37. Pushed by apol into branch 'master'. Use update-high as the updates page icon if there's security updates M +1 -1 discover/qml/DiscoverWindow.qml M +14 -3 libdiscover/backends/PackageKitBackend/PackageKitBackend.cpp M +2 -0 libdiscover/backends/PackageKitBackend/PackageKitBackend.h M +6 -0 libdiscover/resources/AbstractResourcesBackend.h M +11 -0 libdiscover/resources/ResourcesModel.cpp M +2 -0 libdiscover/resources/ResourcesModel.h https://commits.kde.org/discover/0c1c5a16a7d6a52d6026b84ef094a2f2f258d2ab This is marked as fixed but I still can't tell which are the security updates Indeed. However I think what Aleix was saying is that this isn't something we want to do. The System Tray Notifier's only UI is a tooltip; we can't put information on every package in there; it would get absurdly large. Indeed. But I think the expectation -- certainly mine, but also what I read in the Description -- is to show which updates are security updates in Discover, not in the notifier. Instead of marking each update accordingly, IIUC Aleix changed the whole page icon for updates to match that in the notifier. That does not add information. Ah, ok. |