| Summary: | [hidpi] Preview shows thumbnails bar bigger than preview | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | freddi34 |
| Component: | Thumbs-BarView | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles |
| Priority: | NOR | ||
| Version: | 5.5.0 | ||
| Target Milestone: | --- | ||
| Platform: | Appimage | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 8.1.0 | |
| Sentry Crash Report: | |||
| Attachments: |
Screenshot of UI layout after switching to Preview
Screenshot of UI layout after moving the separator of the thumbnails bar to its limit (same for separator of sidebar) |
||
Created attachment 106059 [details]
Screenshot of UI layout after moving the separator of the thumbnails bar to its limit (same for separator of sidebar)
>Since the size is not saved when closing the program the user has to redo this >everytime the program is opened.
Can you imagine seriously that we don't save the GUI geometry properties ???
Not reproducble here with 5.6.0. The thumbbar size is stored in digikamrc file as expected.
Gilles Caulier
>Since the size is not s̶a̶v̶e̶d̶ restored
After updating to the 5.6.0 appimage it is still reproducible. It actually seems the thumbbar is restored to 2× the previous size.
Is it stored in correct size but incorrectly restored when reading from digikamrc?
Or is it stored in 2× size (pixels) and restored as read from digikamrc (virtual pixels) ?
Another part of the report is that the minimum height of the thumbbar is way too big, that means just at the minimum height the size is acceptable and I can imagine other people prefer smaller thumbnails. While not questioning in any way the lower limit, this could be a hint that the min-height maybe also does not properly work on HiDPI displays. That means with a UI scaling factor of 2×, the min-height becomes 4× the original min-height in physical pixels.
[LightTable Thumbbar]
Height 600=402
Height 900=741
State=AAAA/wAAAAD9AAAAAQAAAAIAAAJcAAABBvwBAAAAAfsAAAAmAGwAaQBnAGgAdAB0AGEAYgBsAGUAXwB0AGgAdQBtAGIAYgBhAHIAAAAAAAAAAlwAAAA4AP///wAAAlwAAACIAAAABAAAAAQAAAAIAAAACPwAAAAA
ToolBarsMovable=Disabled
Width 1067=604
Width 1600=1520
Problem still reproducible with AppImage bundle 6.0.0-beta1 available here : https://files.kde.org/digikam/ Gilles Caulier After 3 weeks of work, i finally completed the compilation of AppImage using Qt 5.11.3 + QWebkit 5.212. New 6.1.0 pre-release AppImage bundle can be found here (64 bits only for the moment) : https://files.kde.org/digikam/ Please check if this bugzilla entry still valid. Thanks in advance Gilles Caulier Git commit cb6b0ef7519471b78e7cd04807af24b2f893e982 by Maik Qualmann. Committed on 03/05/2019 at 16:53. Pushed by mqualmann into branch 'master'. fix HiDPI problem under Linux # 1 - Preview - Light Table - Image Editor - Slideshow - Thumbnails not yet Related: bug 403197, bug 371005 M +4 -2 core/libs/widgets/graphicsview/graphicsdimgitem.cpp M +2 -1 core/utilities/imageeditor/widgets/imagepreviewitem.cpp M +2 -1 core/utilities/slideshow/slideimage.cpp https://invent.kde.org/kde/digikam/commit/cb6b0ef7519471b78e7cd04807af24b2f893e982 Git commit 4c8c1f998d03064fc5e92a9d0214394965f52cb5 by Maik Qualmann. Committed on 05/05/2019 at 07:57. Pushed by mqualmann into branch 'master'. fix zoom image on HiDPI display Related: bug 371005, bug 403197 FIXED-IN: 6.2.0 M +2 -1 NEWS M +4 -0 core/dplugins/generic/view/glviewer/glviewertexture.cpp M +2 -2 core/libs/widgets/graphicsview/graphicsdimgitem.cpp M +18 -14 core/libs/widgets/graphicsview/imagezoomsettings.cpp M +2 -1 core/libs/widgets/graphicsview/imagezoomsettings.h M +2 -2 core/utilities/imageeditor/widgets/imagepreviewitem.cpp https://invent.kde.org/kde/digikam/commit/4c8c1f998d03064fc5e92a9d0214394965f52cb5 digiKam 7.0.0 stable release is now published: https://www.digikam.org/news/2020-07-19-7.0.0_release_announcement/ We need a fresh feedback on this file using this version. Best Regards Gilles Caulier Maik, Do you plan more patch for HDPI support here ? Gilles Problem is not reproducible with my HidpI screens. Closed |
Created attachment 106058 [details] Screenshot of UI layout after switching to Preview When clicking on a thumbnail in Thumbnails view switches to a Preview view with a horizontal thumbnails bar on top and the selected photo previewed below. On a high-dpi screen (with QT_AUTO_SCREEN_SCALE_FACTOR=1 and QT_DEVICE_PIXEL_RATIO not set), this thumbnails bar defaults to huge size (like 2×2× normal size). The user can drag the separator of the thumbnails bar to reduce it, but the minimum thumbnails bar height is still bigger than normal and leave little usable space for the preview of the selected photo. Since the size is not saved when closing the program the user has to redo this everytime the program is opened.