Summary: | Expose a user-facing setting to change QStyle::SH_ScrollBar_LeftClickAbsolutePosition | ||
---|---|---|---|
Product: | [Applications] systemsettings | Reporter: | Nate Graham <nate> |
Component: | kcm_style | Assignee: | Nate Graham <nate> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | aria, ascaris, bfeber, bugseforuns, hugo.pereira.da.costa, jplx256, mountybike, nate, nfxjfg, tempel.julian |
Priority: | NOR | Keywords: | usability |
Version: | 5.9.5 | ||
Target Milestone: | --- | ||
Platform: | openSUSE | ||
OS: | Linux | ||
See Also: |
https://bugs.kde.org/show_bug.cgi?id=402578 https://bugs.kde.org/show_bug.cgi?id=384889 https://bugs.kde.org/show_bug.cgi?id=412685 |
||
Latest Commit: | https://cgit.kde.org/plasma-desktop.git/commit/?id=759cec4645e03a389e5b9619e97b128f4781aa67 | Version Fixed In: | 5.18.0 |
Sentry Crash Report: |
Description
Nate Graham
2017-05-04 03:29:47 UTC
But middle click works? (In reply to Christoph Feck from comment #1) > But middle click works? here yes, at least Yes, it does. I just prefer having the scroll bar move with a left-click in the trough, not a middle-click. Middle-clicking is annoying with a touchpad, which is what I'm using 95% of the time. (In reply to Christoph Feck from comment #1) > But middle click works? I wonder if this should not be added to upstream "kstyle" rather than breeze. It is not really a style specific feature, is it? And this way both oxygen and breeze (and any other kstyle derived widget style) would benefit from the extra option. We could then add the extra option not to breeze configuration but rather to the "Fine tuning" tab of the widget style kcm. wdyt ? That's an excellent idea! You're right, this isn't really Breeze-specific. *** Bug 387363 has been marked as a duplicate of this bug. *** *** Bug 398067 has been marked as a duplicate of this bug. *** I really would love to have the ability to jump to the scrollbar position also with primary mouse button (not middle mouse button) in Qt applications. *** Bug 401219 has been marked as a duplicate of this bug. *** *** Bug 408409 has been marked as a duplicate of this bug. *** I should finally do this. (In reply to Nate Graham from comment #11) > I should finally do this. The GTK KCM already has this, so when the Application Style KCM has it too and we have the GTK settings synchronization structure then we can set that option for GTK there too. Yeah. Though upon reflection, I'm gonna put it in the General Behavior rather than Application style since it will affect all scrollbars including in Plasma, which is not an application, so it doesn't make sense IMO to put it in a KCM that's explicitly only about apps. Having started already, it looks like this actually may not be all that hard. *** Bug 402218 has been marked as a duplicate of this bug. *** Here's a patch that implements this feature for Qt/KDE apps at least: https://phabricator.kde.org/D25361 Other patches will be required to get scrollbars in Plasma (Bug 384889) and QML-based desktop apps (Bug 412685) to follow suit. Git commit dcadc14c952df6a25a357dbaad16ebde15b438a8 by Nate Graham. Committed on 02/12/2019 at 18:18. Pushed by ngraham into branch 'master'. Conditionally set SH_ScrollBar_LeftClickAbsolutePosition based on kdeglobals setting Summary: CCBUG: 379498 Test Plan: - Set `ScrollbarLeftClickNavigatesByPage=true` in the `[KDE]` section of ~/.config/kdeglobals - Click in the scroll trough in a Qt/KDE app - See that the scroll handle position jumps right there - Set `ScrollbarLeftClickNavigatesByPage=false` or remove it from kdeglobals - Click in the scroll trough in a Qt/KDE app - See that the scroll handle moves up or down by one page height Reviewers: #frameworks, #plasma Subscribers: broulik, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D25360 M +5 -0 src/kstyle/kstyle.cpp https://commits.kde.org/frameworkintegration/dcadc14c952df6a25a357dbaad16ebde15b438a8 Thank you! Can’t wait to see it fully implemented. You're very welcome! Thanks, Nate! Plasma 5.18 really comes with handy changes. You're welcome! Huh, it works in Okular, but for whatever reason not in LibreOffice Writer with kde5 VCL. There only middle mouse button jumps directly to the position, left mouse button doesn't. I can confirm it works in KDE Applications, VLC, Firefox, Thunderbird, but not in LibreOffice. That's a bug in LibreOffice. Please file a bug for them, telling them that when using the KDE5 VCL, they should respect QStyle::SH_ScrollBar_LeftClickAbsolutePosition. Then paste a link to the bug report here. :) |