Bug 379432

Summary: Folder label length in folder view decreases with icon size
Product: [Plasma] plasmashell Reporter: none <idontactuallywantthisemail>
Component: FolderAssignee: Eike Hein <hein>
Status: RESOLVED FIXED    
Severity: normal CC: antonio.mario.caruso, bugseforuns, darkwingbuck13, kde, milakam, nate, plasma-bugs, sabayon11, sb56637, simonandric5
Priority: NOR Keywords: usability
Version: 5.9.5   
Target Milestone: 1.0   
Platform: Kubuntu   
OS: Linux   
Latest Commit: Version Fixed In: 5.12.8
Sentry Crash Report:
Attachments: Room for titles: folder view vs Dolphin
Kubuntu optimized, Kubuntu & Windows Compareison
Horizontal Space between icons

Description none 2017-05-02 10:05:54 UTC
I prefer small icons, but when i decrease the desktop folder icon sizes, the label length decreases and only allows 4 or 5 letters at the most..

I thought it would be nice to be able to have an option which independently sets the label length, regardless of icon size.

Thanks
Comment 1 apache 2018-02-23 11:53:50 UTC
I second this request. 
Is it possible to set font size of desktop icons in folder view regardless of general Plasma settings? I don't want font size of desktop icons to affect other system settings. When I set icon size that fits my preference font size is to big to fit in one row, but I don't make icons bigger. This is in Plasma 5.12.2
https://imgur.com/a/Kaogc
Comment 2 apache 2018-02-23 17:13:46 UTC
As a comparison this is how it was in KDE Plasma 4:
https://i.imgur.com/NaXo6c6.png
https://i.imgur.com/ACqr2wK.png
In both cases I set two lines for icon's name.
Comment 3 apache 2018-03-01 09:42:04 UTC
Please disregard my comments, it was false alarm. It is ok now.
Comment 4 Nate Graham 2018-03-02 23:07:12 UTC
*** Bug 390531 has been marked as a duplicate of this bug. ***
Comment 5 Nate Graham 2018-03-02 23:08:11 UTC
Created attachment 111153 [details]
Room for titles: folder view vs Dolphin
Comment 6 Nate Graham 2018-03-02 23:15:16 UTC
*** Bug 380272 has been marked as a duplicate of this bug. ***
Comment 7 sac 2018-03-03 09:34:45 UTC
Created attachment 111161 [details]
Kubuntu optimized, Kubuntu & Windows Compareison
Comment 8 sac 2018-03-03 09:35:28 UTC
Comparism Win Kubuntu & Optimized

Approximately 8 characters from a filename are displayed, which makes folderview almost unusable. 

- Alot of space is wasted above, below and next to a desktop symbol item. 
- Table grid layout is unlogic (symbol item has more height instead of more width)
- Renaming a long filename is a mess (no bigger text box is shown that displays the whole filename, while navigating with the mouse within the rename text box a selection is made on the desktop)

Comparism & detailed misaligned pixels displayed in the screenshot.

Overall FV should be verified in terms of visibility, usability & screen space efficiency.
Comment 9 Nate Graham 2018-03-15 19:43:50 UTC
Git commit 8208d9b3b3b9ba903b09a5e173031296a5688d43 by Nathaniel Graham.
Committed on 15/03/2018 at 19:28.
Pushed by ngraham into branch 'master'.

Give file and folder names a bit more room in Folder View

Summary:
Slightly decrease the side margins within Folder View delegates, to give titles a tiny bit more room. This very slightly improves things for people who have desktop files with multi-line titles.

Test Plan:
Before, normal-sized icons:
{F5755097}

After, normal-sized icons:
{F5755128}

Before: small icons:
{F5755102}

After, small icons:
{F5755127}

Reviewers: hein, #plasma

Reviewed By: hein, #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D11358

M  +1    -1    containments/desktop/package/contents/ui/FolderItemDelegate.qml

https://commits.kde.org/plasma-desktop/8208d9b3b3b9ba903b09a5e173031296a5688d43
Comment 10 Nate Graham 2018-07-18 21:53:37 UTC
So this is half completed. The available space is increased for any given icon size, but it does still decrease as icon size is reduced. Re-titling to track that remaining issue.
Comment 11 Nate Graham 2018-07-18 23:14:20 UTC
Git commit 02dadc40efb4fbe7425902fc236b06ca729d848b by Nate Graham, on behalf of Nathaniel Graham.
Committed on 18/07/2018 at 23:13.
Pushed by ngraham into branch 'Plasma/5.12'.

Give file and folder names a bit more room in Folder View

Summary:
Slightly decrease the side margins within Folder View delegates, to give titles a tiny bit more room. This very slightly improves things for people who have desktop files with multi-line titles.

Test Plan:
Before, normal-sized icons:
{F5755097}

After, normal-sized icons:
{F5755128}

Before: small icons:
{F5755102}

After, small icons:
{F5755127}

Reviewers: hein, #plasma

Reviewed By: hein, #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D11358

M  +1    -1    containments/desktop/package/contents/ui/FolderItemDelegate.qml

https://commits.kde.org/plasma-desktop/02dadc40efb4fbe7425902fc236b06ca729d848b
Comment 12 Nate Graham 2018-10-08 14:18:30 UTC
*** Bug 399498 has been marked as a duplicate of this bug. ***
Comment 13 sac 2018-11-11 04:17:50 UTC
Kind of a workaround (mentioned in Kubuntuforum):

1. Edit "/usr/share/plasma/plasmoids/org.kde.desktopcontainment/contents/ui/FolderView.qml"
2. Replace 
"var iconWidth = iconSize + (2 * units.largeSpacing) + (2 * units.smallSpacing);"
with 
"var iconWidth = iconSize + (4 * units.largeSpacing) + (2 * units.smallSpacing); //Multiplier changed to 4"
3. Replace 
"var iconHeight = iconSize + (theme.mSize(theme.defaultFont).height * plasmoid.configuration.textLines) + (4 * units.smallSpacing);"
with
"var iconHeight = iconSize + (theme.mSize(theme.defaultFont).height * plasmoid.configuration.textLines) + (2 * units.smallSpacing); //Multiplier changed to 2"

I'm not sure if the "Grid Way" is the right solution. Personally, I'd love to have an option to position the Icons freely myself, without any Grid constraints. Disadvantage: wouldn't be that accurate, Advantage: I can gain space and position them exactly where I want, so that the icon doesn't "jump" to the near grid line.
Comment 14 sac 2018-11-11 23:25:13 UTC
Created attachment 116251 [details]
Horizontal Space between icons

Does anyone no why there is still a space between  the icons or how I can get rid of this, too?
Comment 15 Nate Graham 2018-11-15 16:03:34 UTC
Here's a patch: https://phabricator.kde.org/D16901
Comment 16 Nate Graham 2018-11-29 16:19:25 UTC
Git commit 0b654afd88844c5a0ab8eb9a4f639ab52eac6d57 by Nate Graham.
Committed on 29/11/2018 at 16:19.
Pushed by ngraham into branch 'Plasma/5.12'.

[Folder View] implement a minimum width for icon view to ensure that labels are never rendered useless

Summary:
Currently with Folder-View-on-the-desktop, items' labels become illegibe when the icon size is very small.

This patch implements a minimum width when using on-the-desktop icon view to make sure that the label is never uselessly short when using very small icons.
FIXED-IN: 5.12.8

Test Plan:
Smallest size, before: {F6426124}
Smallest size, after: {F6426126}
Equal padding on either side of the container itself still works: {F6426129}

There is no change for sizes corresponding to the fourth tick on the slider and beyond

Reviewers: #plasma, #vdg, hein

Reviewed By: #plasma, hein

Subscribers: abetts, broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D16901

M  +3    -2    containments/desktop/package/contents/ui/FolderView.qml

https://commits.kde.org/plasma-desktop/0b654afd88844c5a0ab8eb9a4f639ab52eac6d57