| Summary: | Add ISA 3.0B additional isnstructions, add OV32, CA32 setting support | ||
|---|---|---|---|
| Product: | [Developer tools] valgrind | Reporter: | Carl Love <cel> |
| Component: | vex | Assignee: | Julian Seward <jseward> |
| Status: | CLOSED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | 3.10 SVN | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Attachments: | ISA 3.0 additional instructions, fixes code changes only | ||
|
Description
Carl Love
2017-04-18 18:42:18 UTC
Created attachment 105140 [details]
ISA 3.0 additional instructions, fixes code changes only
The attached patch adds the needed support for the additional instructions. It also adds support for the OV32 and CA32 bits to the existing arithmetic instructions. The issue here with the OV32 and CA32 bit is several of the existing test cases will now run differently on pre ISA3.0 HW versus ISA3.0 HW. Valgrind will match the functionality of the pre ISA3.0 and ISA3.0 HW. The older test cases were refactored to put the instructions that don't change into one test and the instruction that change into another. This way we can now mininimize the size of the expect files for pre ISA 3.0 and ISA3.0 results. These changes to the test code is included in the patch.
I have not bothered to post the patch with the changes to the expect files. I don't think that is of much interest but will be included when the patch is applied.
Please review the patch and let me know if you have any questions, comments or concerns. Thanks.
Attached patch was committed, Vex commit 3359 The test case result files, test case changes are in Valgrind commit 16329 There is a lot of changes to the test case outputs. I think it is all fine but will leave this Bug open until I verify the regression tests are OK. The nightly regression tests look fine. Closing |