Bug 378477

i've see that the current of the screen is italian, sorry. Anyway i think that you can guess that "rating" is translated in "valutazione personale"

I can't confirm at the moment - everything shows up properly for me. I wonder if there's a problem with the Ubuntu packaging possibly? I'm not sure where the default installation on Ubuntu is. Can you check to see if there's a /usr/share/tellico/pics/star_on.png file, for example?

If you run from the command line, is there any output that might seem to be relevant?

If you can provide the information requested in comment #2, please add it.

Sorry if I reply this late, by the way yeah, the star_on.png file is present, and i noticed later that is present even in the entry view. About the packages I don't know honestly, I remember that I tried twice to repair them and nothing changed,then, regarding what you wrote about run it from the command line, at the moment I'm using the 2.3.9 version to adjust some of the record I made, when i finish that I'll upgrade to 3.0.1 and I'll try that.

(In reply to Robby Stephenson from comment #2)
> I can't confirm at the moment - everything shows up properly for me. I
> wonder if there's a problem with the Ubuntu packaging possibly? I'm not sure
> where the default installation on Ubuntu is. Can you check to see if there's
> a /usr/share/tellico/pics/star_on.png file, for example?
> 
> If you run from the command line, is there any output that might seem to be
> relevant?

I'm on Debian Sid. I have had the same problem with Tellico v.3.0.2, and the graphics files (star_on.png, stars1.png, ...) were present in /usr/share/tellico/pics/. The stars appears in the XML file rendering but not on the interface. Finaly i downgrade to Tellico 2.3.9 because Tellico v.3.0.2 can't write without crashing.

Created attachment 105915 [details]
A sreenshot of the interface. See the stars on the xml preview AND NOT on the interface

On the xml preview you can see "Quality (record)" and "Quality (game)" with 5 stars, and on the interface in the same entry field no star is displayed.

Thanks for the screenshots. Looking at them, there are other missing icons in the UI., too, it appears. The Filters tab should have an icon, the Nouveau button should have one, etc...checkmark icons probably don't shown in the column view, either, right?

That symptom gives me a few pointers to go check...

Created attachment 106134 [details]
A screenshot of the same database with Tellico downgraded to 2.3.9

A screenshot of the same database (under the same MATE window manager) with Tellico downgraded to 2.3.9.
I only change the pixmap by others i had found on internet (for the stars & checkmark.png, in /usr/share/kde4/apps/tellico/pics), and in the appearance of the windows manager for the scroll bars.

Created attachment 106136 [details]
Checkmark icon not present in the column view

Checkmark icon not present in the column view : See the "Daedalus - No Escape" entry ("Commercial" is checked, and the "Check" icon isn't displayed in the column view above.

(In reply to Robby Stephenson from comment #7)
> Thanks for the screenshots. Looking at them, there are other missing icons
> in the UI., too, it appears. The Filters tab should have an icon, the
> Nouveau button should have one, etc...checkmark icons probably don't shown
> in the column view, either, right?
> 
> That symptom gives me a few pointers to go check...

Thanks for you attention. I confirm your observations (see the screenshots above) : checkmark icons don't shown in the column view.

To avoid a possible packaging problem, i compile Tellico 3.0.2 myself and install it (# make install). I have the same problem : no icons on its interface, the icons are present on /usr/share/tellico/pics, and Tellico crash when i save the database.

Git commit 94376ac3c82942a26c2cf748a5072278c57e6405 by Robby Stephenson.
Committed on 22/06/2017 at 02:16.
Pushed by rstephenson into branch 'master'.

Add a QRC file for the internal icons

Use the internal resources icons when appropriate. Otherwise, check for
icons from the theme and fall back to internal ones when needed.

I can't verify this, but I expect it to fix Bug 378477.

Also scrub icons from several data sources.
FIXED-IN: 3.1

A  +51   -0    icons/icons.qrc
M  +4    -0    src/CMakeLists.txt
M  +2    -1    src/borrowerdialog.cpp
M  +1    -1    src/configdialog.cpp
M  +2    -2    src/entryeditdialog.cpp
M  +1    -1    src/fetch/amazonfetcher.cpp
M  +1    -1    src/fetch/bibliosharefetcher.cpp
M  +1    -1    src/fetch/bibsonomyfetcher.cpp
M  +1    -1    src/fetch/boardgamegeekfetcher.cpp
M  +1    -1    src/fetch/hathitrustfetcher.cpp
M  +1    -1    src/fetch/ibsfetcher.cpp
M  +1    -1    src/fetch/imdbfetcher.cpp
M  +1    -1    src/fetch/moviemeterfetcher.cpp
M  +1    -1    src/fetch/musicbrainzfetcher.cpp
M  +1    -1    src/fetch/openlibraryfetcher.cpp
M  +1    -1    src/fetch/videogamegeekfetcher.cpp
M  +1    -1    src/fetch/z3950fetcher.cpp
M  +4    -3    src/fetchdialog.cpp
M  +4    -4    src/groupview.cpp
M  +2    -2    src/gui/collectiontypecombo.cpp
M  +2    -2    src/gui/ratingwidget.cpp
M  +1    -1    src/gui/starrating.cpp
M  +3    -1    src/loandialog.cpp
M  +3    -1    src/main.cpp
M  +34   -22   src/mainwindow.cpp
M  +1    -1    src/models/borrowermodel.cpp
M  +2    -2    src/models/entrygroupmodel.cpp
M  +3    -3    src/models/entrymodel.cpp
M  +1    -1    src/models/filtermodel.cpp
M  +2    -2    src/utils/tellico_utils.cpp

https://commits.kde.org/tellico/94376ac3c82942a26c2cf748a5072278c57e6405

(In reply to Robby Stephenson from comment #11)
> Git commit 94376ac3c82942a26c2cf748a5072278c57e6405 by Robby Stephenson.
> Committed on 22/06/2017 at 02:16.
> Pushed by rstephenson into branch 'master'.
> 
> Add a QRC file for the internal icons
> 
> Use the internal resources icons when appropriate. Otherwise, check for
> icons from the theme and fall back to internal ones when needed.
> 
> I can't verify this, but I expect it to fix Bug 378477.
> 
> Also scrub icons from several data sources.
> FIXED-IN: 3.1
> 
> A  +51   -0    icons/icons.qrc
> M  +4    -0    src/CMakeLists.txt
> M  +2    -1    src/borrowerdialog.cpp
> M  +1    -1    src/configdialog.cpp
> M  +2    -2    src/entryeditdialog.cpp
> M  +1    -1    src/fetch/amazonfetcher.cpp
> M  +1    -1    src/fetch/bibliosharefetcher.cpp
> M  +1    -1    src/fetch/bibsonomyfetcher.cpp
> M  +1    -1    src/fetch/boardgamegeekfetcher.cpp
> M  +1    -1    src/fetch/hathitrustfetcher.cpp
> M  +1    -1    src/fetch/ibsfetcher.cpp
> M  +1    -1    src/fetch/imdbfetcher.cpp
> M  +1    -1    src/fetch/moviemeterfetcher.cpp
> M  +1    -1    src/fetch/musicbrainzfetcher.cpp
> M  +1    -1    src/fetch/openlibraryfetcher.cpp
> M  +1    -1    src/fetch/videogamegeekfetcher.cpp
> M  +1    -1    src/fetch/z3950fetcher.cpp
> M  +4    -3    src/fetchdialog.cpp
> M  +4    -4    src/groupview.cpp
> M  +2    -2    src/gui/collectiontypecombo.cpp
> M  +2    -2    src/gui/ratingwidget.cpp
> M  +1    -1    src/gui/starrating.cpp
> M  +3    -1    src/loandialog.cpp
> M  +3    -1    src/main.cpp
> M  +34   -22   src/mainwindow.cpp
> M  +1    -1    src/models/borrowermodel.cpp
> M  +2    -2    src/models/entrygroupmodel.cpp
> M  +3    -3    src/models/entrymodel.cpp
> M  +1    -1    src/models/filtermodel.cpp
> M  +2    -2    src/utils/tellico_utils.cpp
> 
> https://commits.kde.org/tellico/94376ac3c82942a26c2cf748a5072278c57e6405

Thank you for your great job. I will test this new version.

Instead of adding code to all applications, we rely on platform tools to set correct paths for icon themes.

For Plasma, this is part of the plasma-integration and frameworks-integration plugins.

If you use KDE applications outside of the Plasma environment, please use "qt5ct". This comes with both a platform plugin, as well as a configuration tool to change Qt5 fonts, icons, and other UI settings.

You are of course free to use hardcoded icons from QRC resources, but users of KDE applications usually expect that these follow the locale icon theme configuration.

For more information about "qt5ct", please see https://wiki.archlinux.org/index.php/qt#Configuration_of_Qt5_apps_under_environments_other_than_KDE_Plasma and https://sourceforge.net/projects/qt5ct/

If I understand you correctly, I think I'm following the spirit of what you're saying. For icons which could be expected to be in the icon theme, I use QIcon::fromTheme() with the method call that falls back to a resource icon. For example, QIcon::fromTheme("checkmark", QIcon(":/icons/checkmark")).

For icons which I specifically don't want to be themed, then I just use the resource call. An example there would be wine.png which represents a wine bottle in Tellico. Many themes could reasonably be expected to have an application icon for WINE instead so I wouldn't want to use the theme icon in that case.

For whatever reason, the two users who reported the bug did not see the icons as installed. I could not reproduce the problem since they showed up just fine for me. I don't know if it is a Debian/Ubuntu issue or something else. If indeed this fixes the problem for those users, seems like a win/win to me.

*** Bug 384528 has been marked as a duplicate of this bug. ***