| Summary: | [PATCH] Mixed up color variable and wrong indexing in apply-stylesheet.sh | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] libplasma | Reporter: | Andreas <andi.berger> |
| Component: | libplasma | Assignee: | David Edmundson <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bshah, plasma-bugs-null |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/plasma-framework/874a7e39b92285e2edeb74c14c05fbf02efe4934 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: | patch, fixes the issue | ||
sorry, i put this in the wrong section i'm not sure where to put this exactly, i'm fairly certain it belongs somewhere under frameworks-plasma, but not sure which subsection. also, i'm not sure which version i have to pick here, it's from the git master. sorry again, i am new to this, if i made an error please reassign it again Git commit 874a7e39b92285e2edeb74c14c05fbf02efe4934 by Marco Martin. Committed on 24/03/2017 at 12:46. Pushed by mart into branch 'master'. fix typo, iterate all colors available patch by andi.berger@yandex.com M +2 -2 src/tools/apply-stylesheet.sh https://commits.kde.org/plasma-framework/874a7e39b92285e2edeb74c14c05fbf02efe4934 |
Created attachment 104690 [details] patch, fixes the issue I found this in /plasma-framework/src/tools/apply-stylesheet.sh (a helper script for creating plasma themes) Steps to reproduce: 1) use the script to make a plasma theme color-scheme-aware Result: 1) the button hover color is not assigned as expected 2) all but the first 5 color variables are not assigned at all Problem: 1) under --ButtonHoverFrom) it assigns buttonBackgroundFrom (again) instead of buttonHoverFrom 2) the loop should obviously go over the entire array of color variables, but is hardcoded to 5 iterations, i changed it to the array lenght see patch, attached