| Summary: | Database directory ignoring hidden and unnecessarily in migration-dialogue [patch] | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Simon <freisim93> |
| Component: | Setup-Database | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles |
| Priority: | NOR | ||
| Version: | 5.5.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/digikam/fe004359a3d73a69c8958a532e88f8a6c9355f5a | Version Fixed In: | 5.6.0 |
| Sentry Crash Report: | |||
| Attachments: | Put ignored directories in its own tab | ||
The idea sound fine for me. I do not see any problem in patch (not tested). Gilles @Gilles did you get a chance to test? It worked fine for me. yes, i will do it... PAtch work fine for me... Gilles Git commit fe004359a3d73a69c8958a532e88f8a6c9355f5a by Simon Frei. Committed on 19/03/2017 at 13:02. Pushed by sfrei into branch 'master'. Move ignoring directories to its own tab in configuration FIXED-IN: 5.6.0 M +2 -1 NEWS M +0 -72 libs/database/utils/dbsettingswidget.cpp M +0 -4 libs/database/utils/dbsettingswidget.h M +124 -39 utilities/setup/setupdatabase.cpp M +9 -0 utilities/setup/setupdatabase.h https://commits.kde.org/digikam/fe004359a3d73a69c8958a532e88f8a6c9355f5a |
Created attachment 104584 [details] Put ignored directories in its own tab Problem: The new functionality to ignore directories is hidden (as in you need to scroll down a lot) as the database configuration widget is now very long. Also this options do not really matter for database migration, but come up there as well now. This dialogue is already pretty text heavy, this just adds additional needless complexity. Solution: Take ignoring directories out of DatabaseSettingsWidget and add it to SetupDatabase as a new tab.