| Summary: | Artifacts when flattening animated layer with transform mask | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | z-uo <nicolas.bougere> |
| Component: | Animation | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | eoinoneill1991, halla, joupent |
| Priority: | NOR | ||
| Version: | 3.1.2 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Attachments: |
an exemple of the result
animation before transformation animation after transformation with part of some frames copied on other frames |
||
Hm, this is logical, I guess... I see that all frames get the transform mask applied. I'm not sure where this happens, though, and I don't see artefacts. Note: 10:40:52 < Animtim> if it's about the transform mask being applied on every frame, that is by design and not a bug (very useful to move around a complete animation..) But then we still have the issue that the transform mask is only applied to the current frame on creation. I wonder whether it gets applied to all frames on saving/loading. Created attachment 104552 [details]
animation before transformation
Created attachment 104553 [details]
animation after transformation with part of some frames copied on other frames
Maybe my exemple wasn't clear, watch the two new attachments to understand the problem. (and the transform mask is very usefull with animation, I agree) Clarification: parts of the currently active frame remain in flattened versions of any frames with smaller bounds Git commit a8c1d0263847f2b921def037033ff1d550e343fa by Eoin O'Neill. Committed on 12/02/2021 at 01:55. Pushed by eoinoneill into branch 'master'. Attempt to fix artifacts regarding transform masks and animated layer combinations. M +5 -5 libs/image/kis_layer_utils.cpp M +13 -0 libs/image/kis_transform_mask.cpp https://invent.kde.org/graphics/krita/commit/a8c1d0263847f2b921def037033ff1d550e343fa |
Created attachment 104504 [details] an exemple of the result the steps: start an animation with 5 frames Draw something on each frame (tiny things and big things in different places of the canvas) add a transform layer to the animation layer reduce the size flatten the layer the result is some part of drawings in bigs frames are copied in tiny frames