| Summary: | Fails to build on windows missing winsock library | ||
|---|---|---|---|
| Product: | [Applications] konversation | Reporter: | brkopac |
| Component: | general | Assignee: | Konversation Developers <konversation-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | hein |
| Priority: | NOR | ||
| Version: | 1.6 | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | https://commits.kde.org/konversation/76bb64da6265554ec01ba80a9dbb5833c1165e37 | Version Fixed In: | 1.7.0 |
| Sentry Crash Report: | |||
| Attachments: | log from craft | ||
Does it work with the 1.7 or master branches? There have been Windows build fixes since 1.6. Our Windows guy could reproduce, we might have a fix coming. Patch under review: https://phabricator.kde.org/D5237 Git commit 76bb64da6265554ec01ba80a9dbb5833c1165e37 by Kevin Funk. Committed on 29/03/2017 at 12:35. Pushed by kfunk into branch '1.7'. Fix compilation under Windows Summary: Under Visual Studio, I actually don't need to link in ws2_32 myself, it works as-is. Better do it explicitly, though, since we do use symbols from ws2_32 (ntohl, etc.). FIXED-IN: 1.7.0 Differential Revision: https://phabricator.kde.org/D5237 M +3 -0 src/CMakeLists.txt M +8 -0 src/dcc/transferrecv.cpp M +8 -0 src/dcc/transfersend.cpp https://commits.kde.org/konversation/76bb64da6265554ec01ba80a9dbb5833c1165e37 |
Created attachment 104487 [details] log from craft konversation fails to link on windows due to it failing to link winsock. I've attached the output log from craft.