Bug 377406

Summary: Fails to build on windows with linker error
Product: [Frameworks and Libraries] frameworks-kdoctools Reporter: brkopac
Component: generalAssignee: Documentation Editorial Team <kde-doc-english>
Status: RESOLVED FIXED    
Severity: critical CC: kde-windows, kdelibs-bugs, luigi.toscano
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: log from craft
Do not link the same functions both directly and through the library meinproc5

Description brkopac 2017-03-09 02:15:49 UTC
Created attachment 104466 [details]
log from craft

kdoctools fails to build using:

craft kdoctools > log 2>&1
Comment 1 Luigi Toscano 2017-03-09 07:58:52 UTC
(In reply to brkopac from comment #0)
> Created attachment 104466 [details]
> log from craft
> 
> kdoctools fails to build using:
> 
> craft kdoctools > log 2>&1

There was a change in KDocTools 5.32 (it finally provides a dynamic library instead of a static one), and I informed the packagers. Unfortunately I can't do anything about it (no environment), so I can only rely on windows packagers.
Comment 2 Luigi Toscano 2017-03-09 08:19:45 UTC
Created attachment 104468 [details]
Do not link the same functions both directly and through the library meinproc5

Unless... can you please try the attached patch? It still compiles locally (tested on Debian), so it may work, if I read the error correctly.
Comment 3 Luigi Toscano 2017-03-09 22:31:42 UTC
Git commit d2186e6786b3f717080a7b4b2264787a40f8d4a0 by Luigi Toscano.
Committed on 09/03/2017 at 21:11.
Pushed by ltoscano into branch 'master'.

meinproc5: link to the files, not to the library

The code worked with the GCC stack on GNU/Linux, but not with MSVC 19.0
(2015).

Reviewed-by: Kevin Funk <kfunk@kde.org>

M  +1    -1    src/CMakeLists.txt

https://commits.kde.org/kdoctools/d2186e6786b3f717080a7b4b2264787a40f8d4a0
Comment 4 brkopac 2017-03-09 22:37:52 UTC
I can confirm this has been fixed. My craft is continuing its build. Thanks very much!