Bug 376712

Summary: Formats module is asking the user to relogin after pressing the Apply button
Product: [Applications] systemsettings Reporter: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0x9b>
Component: kcm_formatsAssignee: Sebastian Kügler <sebas>
Status: RESOLVED UPSTREAM    
Severity: normal    
Priority: NOR    
Version First Reported In: 5.9.2   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Screenshot

Description Jan Ziak (http://atom-symbol.net) 2017-02-20 13:42:47 UTC
Created attachment 104126 [details]
Screenshot

Formats module asks the user to relogin after pressing the Apply button.
Comment 1 Sebastian Kügler 2017-02-20 15:27:57 UTC
That is intended behavior, but thanks for the report.
Comment 2 Jan Ziak (http://atom-symbol.net) 2017-02-20 15:58:27 UTC
(In reply to Sebastian Kügler from comment #1)
> That is intended behavior, but thanks for the report.

Do you mean you agree with storing locale information in immutable LC_* environment variables?
Comment 3 Sebastian Kügler 2017-02-24 09:59:31 UTC
I wrote the code, so yes.
Comment 4 Jan Ziak (http://atom-symbol.net) 2017-02-24 10:34:57 UTC
(In reply to Sebastian Kügler from comment #3)
> I wrote the code, so yes.

Just because some decades ago somebody temporarily solved a problem at hand by storing locale information in environment variables doesn't necessarily imply that it is the right thing to do from a long-term perspective.

I can change the behavior of the getenv() function to anything I like on my machines - the standard immutability of LC_* variables is an issue I can overcome if necessary.