| Summary: | Saturation value in HSV adjustment isn't restored | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Alex <eneeen> |
| Component: | Filter Layers | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | halla, nicholaslapointe8, rkspsm |
| Priority: | NOR | ||
| Version First Reported In: | 3.1.2 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | All | ||
| Latest Commit: | https://commits.kde.org/krita/581b87f6469894f6c7ee1d2f19bbf34883b869be | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: | Fix for incorrect restoration of saturation slider | ||
|
Description
Alex
2017-02-12 17:07:05 UTC
Thanks for your report! I am able to reproduce the issue. Created attachment 104998 [details]
Fix for incorrect restoration of saturation slider
In the UI file (wdg_hsv_adjustment.ui), the minimum value for saturationSpinBox was not set, and hence was taken as default 0, and the minimum value for saturationSlider was set to 0.
I added them and now it seems to work fine.
Thanks for the patch! Git commit 581b87f6469894f6c7ee1d2f19bbf34883b869be by Boudewijn Rempt. Committed on 25/04/2017 at 12:38. Pushed by rempt into branch 'master'. This fixes loading a hsv adjustment from a filter layer and editing them. M +5 -2 plugins/filters/colorsfilters/wdg_hsv_adjustment.ui https://commits.kde.org/krita/581b87f6469894f6c7ee1d2f19bbf34883b869be Can still be reproduced. I've checked current 4.0 alpha and it seems to work fine. Okay, closing. |