| Summary: | layer sometimes says "group not editable" | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | rianisbae |
| Component: | Layer Stack | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | dimula73, halla |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | https://commits.kde.org/krita/a317eeda8b9464e0e775518eb98909db73c53eee | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: | you can see what happens when i try to draw | ||
*** This bug has been marked as a duplicate of bug 376215 *** *** Bug 376215 has been marked as a duplicate of this bug. *** I've seen this happen too, but no idea why it happens... Most probably, the bug happens because one of the parents of the layer is not editable (locked or invisible). Probably, we should make the message a bit more verbose. Hmm.. on a screenshot there seem to be no parent exist :( Ok, I managed to reproduce it: interleaving quick brush strokes with pressing PgUp and PgDown layer switch shortcuts triggers the bug. Git commit 9c57c307302e224edebd87413e86058503205311 by Dmitry Kazakov. Committed on 20/04/2017 at 14:22. Pushed by dkazakov into branch 'krita/3.1'. Use blockUntilOperationsFinished instead of setSystemLocked() This patch effectively removes all the setSystemLocked functionality. It was not used properly for several years already, because all its work is now delegated to the strokes framework. M +2 -19 libs/image/kis_base_node.cpp M +0 -23 libs/image/kis_base_node.h D +0 -43 libs/image/kis_system_locker.h M +0 -1 libs/ui/flake/kis_node_shape.cpp M +4 -3 libs/ui/kis_node_manager.cpp M +17 -11 libs/ui/tool/kis_tool.cc M +3 -3 libs/ui/tool/kis_tool.h M +0 -3 libs/ui/tool/kis_tool_freehand.cc M +1 -1 libs/ui/tool/kis_tool_paint.cc M +1 -4 libs/ui/tool/kis_tool_shape.cc M +1 -3 plugins/tools/basictools/kis_tool_ellipse.cc M +0 -1 plugins/tools/basictools/kis_tool_fill.cc M +1 -4 plugins/tools/basictools/kis_tool_gradient.cc M +1 -3 plugins/tools/basictools/kis_tool_rectangle.cc M +0 -1 plugins/tools/selectiontools/kis_tool_select_elliptical.cc M +0 -1 plugins/tools/selectiontools/kis_tool_select_polygonal.cc M +0 -1 plugins/tools/selectiontools/kis_tool_select_rectangular.cc M +2 -2 plugins/tools/tool_polygon/kis_tool_polygon.cc M +2 -2 plugins/tools/tool_polyline/kis_tool_polyline.cc M +0 -1 plugins/tools/tool_transform2/kis_tool_transform.cc https://commits.kde.org/krita/9c57c307302e224edebd87413e86058503205311 Git commit a317eeda8b9464e0e775518eb98909db73c53eee by Dmitry Kazakov. Committed on 20/04/2017 at 15:14. Pushed by dkazakov into branch 'master'. Use blockUntilOperationsFinished instead of setSystemLocked() This patch effectively removes all the setSystemLocked functionality. It was not used properly for several years already, because all its work is now delegated to the strokes framework. M +2 -16 libs/image/kis_base_node.cpp M +0 -23 libs/image/kis_base_node.h D +0 -43 libs/image/kis_system_locker.h M +1 -1 libs/libkis/Node.cpp M +1 -1 libs/ui/KisImageBarrierLockerWithFeedback.cpp M +1 -1 libs/ui/KisView.cpp M +1 -1 libs/ui/KisViewManager.cpp M +3 -3 libs/ui/KisViewManager.h M +2 -2 libs/ui/canvas/kis_canvas2.cpp M +1 -1 libs/ui/dialogs/KisAnimationCacheUpdateProgressDialog.cpp M +0 -1 libs/ui/flake/kis_node_shape.cpp M +4 -3 libs/ui/kis_node_manager.cpp M +17 -11 libs/ui/tool/kis_tool.cc M +3 -3 libs/ui/tool/kis_tool.h M +0 -3 libs/ui/tool/kis_tool_freehand.cc M +1 -1 libs/ui/tool/kis_tool_paint.cc M +1 -4 libs/ui/tool/kis_tool_shape.cc M +1 -3 plugins/tools/basictools/kis_tool_ellipse.cc M +0 -1 plugins/tools/basictools/kis_tool_fill.cc M +1 -4 plugins/tools/basictools/kis_tool_gradient.cc M +1 -3 plugins/tools/basictools/kis_tool_rectangle.cc M +0 -1 plugins/tools/selectiontools/kis_tool_select_elliptical.cc M +0 -1 plugins/tools/selectiontools/kis_tool_select_polygonal.cc M +0 -1 plugins/tools/selectiontools/kis_tool_select_rectangular.cc M +2 -2 plugins/tools/tool_polygon/kis_tool_polygon.cc M +2 -2 plugins/tools/tool_polyline/kis_tool_polyline.cc M +0 -1 plugins/tools/tool_transform2/kis_tool_transform.cc https://commits.kde.org/krita/a317eeda8b9464e0e775518eb98909db73c53eee |
Created attachment 103911 [details] you can see what happens when i try to draw sometimes when i am drawing on a SINGULAR layer and i try to draw on it it will say "group not editable". this is on a SINGULAR layer!