| Summary: | Dialog for confirming deletion could indicate if a directory is not empty | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kio | Reporter: | Jonathan Wakely <zilla> |
| Component: | general | Assignee: | KIO Bugs <kio-bugs-null> |
| Status: | CONFIRMED --- | ||
| Severity: | wishlist | CC: | dev, elvis.angelaccio, kdelibs-bugs, nate |
| Priority: | NOR | Keywords: | junior-jobs |
| Version: | 5.29.0 | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=153199 | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Jonathan Wakely
2017-02-02 19:31:21 UTC
P.S. the Details view-mode already makes this information available, by only showing the '>' symbol to expand the directory if it is non-empty. So my requested feature isn't needed if you're using view-mode, because you can tell before trying to delete the directory if it's empty. Another way to solve the same problem would be to add some indicator of a non-empty directory for the icons and compact views too. Well, if you have the Information panel visible, it says "Size: O items" for empty folders. However, I agree it would be nice to have a confirmation dialog aware of what is about to being deleted. (Moving to kio where this belongs) Prospective contributor here; was looking through the 'junior jobs' to see if there was anywhere I might pitch in, and found this one. I see fundamentally two approaches to addressing this: - work within the current UI structure and tweak, making less intrusive changes - reconsider the current UI structure in the context of the request, and rethink the deletion dialogs themselves in a fundamentally different manner The current deletion confirmation dialogs come in two variations: one containing the URL of a single item to be deleted, and the other containing a list of URLs in the case of multiple items. So a less-intrusive approach would suggest tweaking the displayed URL(s) in a way that conveys the requested information. For example: - file items: `/path/to/file` - empty directory items: `/path/to/directory/empty/` (note trailing slash) - nonempty directory items: `/path/to/directory/nonempty/*` (note trailing slash and suffix asterisk) I can anticipate there may be some edge cases to be considered (nonlocal URLs, or expensive-to-determine). A slightly more radical solution might involve (for example) consolidating the two variations into a single dialog that recursively counts the total number of items selected, and presenting both cases as a message along the lines of "Are you sure you want to delete 12,345 items?", which would provide ample warning to somebody expecting to delete a few empty directories. I have no idea how KDE goes about proposing/discussing UI changes, but I imagine that more drastic changes are likely to require a longer process of deliberation; so my 'tweak' proposal might be more likely to be accepted. I'm happy to discuss this, or even attempt to implement the 'tweak' proposal-- open to any suggestions. Thanks for your interest in this, Ben! You can propose UI changes or discuss such ideas in the KDE VDG room; see https://community.kde.org/Get_Involved/design#Getting_started |