Summary: | Drag functionality no longer working with minimized apps | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | Elvis Angelaccio <elvis.angelaccio> |
Component: | Task Manager and Icons-Only Task Manager | Assignee: | Eike Hein <hein> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kde, kde, plasma-bugs, rthomsen6 |
Priority: | NOR | ||
Version: | 5.8.95 | ||
Target Milestone: | 1.0 | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/plasma-desktop/8709b7edd5d17d2369e8ca4d261ec186387fa20e | Version Fixed In: | 5.9.2 |
Description
Elvis Angelaccio
2017-02-01 22:42:59 UTC
It seems to be less reliable than it used to, ie. I sometimes have to wiggle the mouse around on the task item for the window to show up. Just entering the task item doesn't seem to start the raise timer. It still works overall, though. Looks like a regression caused by c50948648012e66b71b757e211432190d592c90d Seems to works fine here: I have two Dolphin's drag from one into the other, and it brings the other into the foreground for dropping. Can you explain exactly what you're dragging. Right, now that I try again seems to work from Dolphin to Dolphin or from FV to Dolphin. Not sure what I did yesterday... Can you try dragging a file from Ark to Dolphin? This definitely stopped working since 5.9 (In reply to Elvis Angelaccio from comment #4) > Can you try dragging a file from Ark to Dolphin? This definitely stopped > working since 5.9 (with Dolphin in the background) I can reproduce when dragging from Ark. It just rejects the drop and Task Manager moves out of the way to make room for dropping onto the panel. This a regression from David's c50948648012e6 which made TM intentionally reject drags without an URL to avoid interfering with drop-on-containment. Possible fix: https://phabricator.kde.org/D4475 Git commit 8709b7edd5d17d2369e8ca4d261ec186387fa20e by David Edmundson. Committed on 08/02/2017 at 15:41. Pushed by davidedmundson into branch 'Plasma/5.9'. Reverse TaskManager DragDrop to blacklist Plasma instead of whitelisting URLs Summary: A previous patch made the task manager only accept drag events which contained URL lists or internal taskmanager mimedata in order to make it easier to drag applets onto the panel. This broke a feature where you can drag arbitrary mimedata between windows and hovering above a task will raise that window. This patch reverses the logic to only ignore plasmoids, and accept all other drag/drops. FIXED-IN: 5.9.2 Test Plan: Dragged applet from Widget explorer onto task manager and the task manager moved to the side to allow a drop. set sorting to manual and moved a task Dragged some text onto a task, and that window raised immediately Reviewers: #plasma Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D4476 M +5 -10 applets/taskmanager/package/contents/ui/MouseHandler.qml https://commits.kde.org/plasma-desktop/8709b7edd5d17d2369e8ca4d261ec186387fa20e |