| Summary: | Kate inadequately proposes to reload deleted file at exit | ||
|---|---|---|---|
| Product: | [Applications] kate | Reporter: | opensuse.lietuviu.kalba |
| Component: | general | Assignee: | KWrite Developers <kwrite-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version First Reported In: | 16.08 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kate/0c15edfbd44fc8b094769b546546ff7a9484cdf2 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | WEBM video | ||
Git commit 0c15edfbd44fc8b094769b546546ff7a9484cdf2 by Christoph Cullmann, on behalf of loh tar. Committed on 04/03/2019 at 18:54. Pushed by cullmann into branch 'master'. [RFC] Defuse KateMainWindow::showModOnDiskPrompt Summary: Related: bug 351443 Test Plan: Fixed in a way as suggested in bug report. Expected Results: Exit without asking (file was not edited since last time in kate, so there is no info to lose) This dialog is for me pretty confusing and annoying. - In which case may that question (without this patch) useful? - Why should I reload a file when I like to close Kate? - Click "Ignore" you will asked again, where you can overwrite the file on disk. The opposite from your first intend. - Click "Diff" keeps the dialog the focus with the result that you can't scroll in the loaded diff. With dark theme is it hard to read too - You can end in some "endless" dialog boxes So, how about to remove that dialog? {F6643583} Reviewers: #kate, cullmann Reviewed By: #kate, cullmann Subscribers: cullmann, ngraham, kwrite-devel, #kate Tags: #kate Differential Revision: https://phabricator.kde.org/D19397 M +2 -1 kate/katemainwindow.cpp https://commits.kde.org/kate/0c15edfbd44fc8b094769b546546ff7a9484cdf2 Git commit 0c15edfbd44fc8b094769b546546ff7a9484cdf2 by Christoph Cullmann, on behalf of loh tar. Committed on 04/03/2019 at 18:54. Pushed by cullmann into branch 'master'. [RFC] Defuse KateMainWindow::showModOnDiskPrompt Summary: Related: bug 351443 Test Plan: Fixed in a way as suggested in bug report. Expected Results: Exit without asking (file was not edited since last time in kate, so there is no info to lose) This dialog is for me pretty confusing and annoying. - In which case may that question (without this patch) useful? - Why should I reload a file when I like to close Kate? - Click "Ignore" you will asked again, where you can overwrite the file on disk. The opposite from your first intend. - Click "Diff" keeps the dialog the focus with the result that you can't scroll in the loaded diff. With dark theme is it hard to read too - You can end in some "endless" dialog boxes So, how about to remove that dialog? {F6643583} Reviewers: #kate, cullmann Reviewed By: #kate, cullmann Subscribers: cullmann, ngraham, kwrite-devel, #kate Tags: #kate Differential Revision: https://phabricator.kde.org/D19397 M +2 -1 kate/katemainwindow.cpp https://commits.kde.org/kate/0c15edfbd44fc8b094769b546546ff7a9484cdf2 |
Created attachment 103707 [details] WEBM video I open several files simultaneously in Kate. I remove non-active file. I close Kate. One of options is funny: to reload deleted file. Reloading this context is meaningless, because program will exit regardless of existence of file: - even if I undo delete of file, after pressing Reload, Kate immediately exit; - if I don't undelete file – Kate also immediately exit. You should remove button "Reload" for this context.