| Summary: | Remove "Tree View" option in settings when built without khtml | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | Elias Probst <mail> |
| Component: | general | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/systemsettings/86f0f92caf0f28fdce3df9e30fc22a67738f92ea | Version Fixed/Implemented In: | 5.12.7 |
| Sentry Crash Report: | |||
| Attachments: | Screenshot showing "View Style" settings | ||
|
Description
Elias Probst
2017-01-10 12:25:58 UTC
Created attachment 103325 [details]
Screenshot showing "View Style" settings
Did you compile it yourself? If not, please ask your packager if they compiled it against KHML dependency. (In reply to Christoph Feck from comment #2) > Did you compile it yourself? If not, please ask your packager if they > compiled it against KHML dependency. Good point - the Gentoo ebuild for kde-plasma/systemsettings provides the "classic" USE flag which pulls in the KF5::KHtml dependency when enabled. So the point I made in my initial comment would be instead: When only one "View Style" option is available, don't show the "View Style" selection at all, as selecting from a single choice doesn't make any sense from a UX perspective. Git commit 86f0f92caf0f28fdce3df9e30fc22a67738f92ea by Kai Uwe Broulik. Committed on 20/07/2018 at 12:34. Pushed by broulik into branch 'Plasma/5.12'. Hide view selection if there is only one plugin to choose FIXED-IN: 5.12.7 Differential Revision: https://phabricator.kde.org/D14247 M +1 -0 app/SettingsBase.cpp https://commits.kde.org/systemsettings/86f0f92caf0f28fdce3df9e30fc22a67738f92ea |