| Summary: | kwin_x11 crach | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | rооt <cerebellum> |
| Component: | core | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | jodr666, kde, L.Bonnaud, nibojczuk |
| Priority: | VHI | Keywords: | drkonqi |
| Version First Reported In: | git master | Flags: | mgraesslin:
X11+
mgraesslin: ReviewRequest+ |
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| URL: | https://phabricator.kde.org/D3808 | ||
| Latest Commit: | https://commits.kde.org/kwin/bba18a1ba812f3a147173edc19516f0e00e7c855 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
rооt
2016-12-22 13:37:36 UTC
You are using an unreleased version in an unreleased distribution. I'm sorry, but there is a fair amount of chance that this setup is just broken. We don't track such issues. I just had the same crash. I changed volume and then kwin kept crashing until I managed to kill plasmashell. Does this have anything to do with your "update OSD when its size changes" patches? (or was that about the kwin internal OSD?)OSD) Reverting 6383f8304711719fe22371474138efc144adc750 fixes (works around) the issue I admit that I didn't test on X11. Can you try moving the new connect from AbstractClient to ShellClient? Then on X11 we don't have this, but on Wayland it would work nevertheless. *** Bug 374147 has been marked as a duplicate of this bug. *** *** Bug 374155 has been marked as a duplicate of this bug. *** Git commit bba18a1ba812f3a147173edc19516f0e00e7c855 by Martin Gräßlin.
Committed on 27/12/2016 at 16:36.
Pushed by graesslin into branch 'master'.
Fix the osd re-placement on X11
Summary:
6383f8304711719fe22371474138efc144adc750 introduced a regression hitting
an assert on X11 when an osd window is added.
This change tries to address this by adding a GeometryUpdateBlocker
around the change. The hit assertion is:
pendingGeometryUpdate() == PendingGeometryNone ||
areGeometryUpdatesBlocked()
By using a GeometryUpdateBlocker the second condition becomes true
and we no longer hit the condition.
Test Plan:
Manual tested both on X11 and Wayland, Wayland autotest
still passes
Reviewers: #kwin, #plasma
Subscribers: plasma-devel, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D3808
M +1 -0 abstract_client.cpp
https://commits.kde.org/kwin/bba18a1ba812f3a147173edc19516f0e00e7c855
Thank you for the quick fix! I confirm that the bug is fixed in this neon package version: Package: kwin-x11 Version: 4:5.8.5+p16.04+git20161228.0449-0 *** Bug 374265 has been marked as a duplicate of this bug. *** |