| Summary: | German names for the christmas holidays are wrong | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kholidays | Reporter: | Tobias Leupold <tl> |
| Component: | general | Assignee: | kdepim bugs <kdepim-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | lueck, tl, winter |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kholidays/d70b7e33ba9b12add232ae331a5cf69db14cef24 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: |
Screenshot
Proposed patch for the German/Bavarian files |
||
|
Description
Tobias Leupold
2016-12-15 14:25:34 UTC
l10n-kf5/de/messages has no translation "Weihnachten". Where do you see this translation? Created attachment 102813 [details]
Screenshot
It shows up when clicking the respective day on the calendar, cf. the attached screenshot.
Burkhard, look in the kholidays repo, there should be a plan2/holiday_de_de Created attachment 102819 [details]
Proposed patch for the German/Bavarian files
Only having had a fast look at the sources, this is what I would propose to change, just to get the spelling right firstly.
I mean, (speaking of the "Bavarian" thingy) the "Wies'n-Sonntag" is surely not a holiday for example. If we add such days, we would also have to add the Gäubodenfest, the Anafest, the Sandkerwa, the Bergkirchweih and so on. I personally would remove such stuff if we want to be serious, but that's another Bug ;-) If you say "Do it", I'll rework the German holidays files (I think they need it). But I would not push to this repository without asking first ... Just now, I'm seeing the Passion Week and the calendar displaying me "Karwoche" for each day. Along with that "1./2./3. Fastensonntag", "Palmsonntag" and whatnot. This really needs to be reworked. Those aren't official holidays and thus should (if at all) go to a specialized religios calendar file or whatever.
If nobody maintains this (apparently nobody does?!), I'll rework it according to the official German ("bundeseinheitliche") and Bavarian Holidays and puh it, okay?
Git commit d70b7e33ba9b12add232ae331a5cf69db14cef24 by Tobias Leupold. Committed on 26/03/2018 at 17:35. Pushed by tleupold into branch 'master'. Reworked the holiday files for Germany. Fixed the common holidays for all federal states according to official sources, and added a file for each federal state that has additional holidays. Also fixed (more rewrote) the existing one for Bavaria. M +11 -0 holidays/holidays.qrc A +66 -0 holidays/plan2/holiday_de-bb_de A +69 -0 holidays/plan2/holiday_de-bw_de M +43 -65 holidays/plan2/holiday_de-by_de A +67 -0 holidays/plan2/holiday_de-hh_de A +66 -0 holidays/plan2/holiday_de-mv_de A +67 -0 holidays/plan2/holiday_de-nw_de A +67 -0 holidays/plan2/holiday_de-rp_de A +66 -0 holidays/plan2/holiday_de-sh_de A +68 -0 holidays/plan2/holiday_de-sl_de A +68 -0 holidays/plan2/holiday_de-sn_de A +67 -0 holidays/plan2/holiday_de-st_de A +67 -0 holidays/plan2/holiday_de-th_de M +32 -28 holidays/plan2/holiday_de_de https://commits.kde.org/kholidays/d70b7e33ba9b12add232ae331a5cf69db14cef24 |