Bug 373555

Summary:	Rename BBPTR to GSPTR as it denotes guest state pointer only
Product:	[Developer tools] valgrind	Reporter:	Ivo Raisr <ivosh>
Component:	vex	Assignee:	Ivo Raisr <ivosh>
Status:	RESOLVED FIXED
Severity:	minor	CC:	ivosh
Priority:	NOR
Version First Reported In:	3.13 SVN
Target Milestone:	---
Platform:	Compiled Sources
OS:	All
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	patch for VEX patch for Valgrind

Description Ivo Raisr 2016-12-12 04:14:05 UTC

VEX currently contains a fossil called "BBPTR", which meant basic block pointer (maybe in some distant past). However through all the VEX, it is used with the meaning of "GSPTR", that is guest state pointer.
It is really confusing to read all over the code about BBPTR but in reality GSPTR is meant.

The attached patch renames BBPTR to GSPTR and fixes also corresponding comments.

Comment 1 Ivo Raisr 2016-12-12 04:18:26 UTC

Created attachment 102737 [details]
patch for VEX

Comment 2 Ivo Raisr 2016-12-12 04:18:56 UTC

Created attachment 102738 [details]
patch for Valgrind

Comment 3 Ivo Raisr 2016-12-16 21:21:31 UTC

Fixed in SVN Valgrind r16189, VEX r3287.