Bug 372788

Summary:	src/core/kfileitem.cpp is still using QFile::symLinkTarget() to get the target of the symbolic link.
Product:	[Frameworks and Libraries] frameworks-kio	Reporter:	taro yamada <archer_ame>
Component:	general	Assignee:	taro yamada <archer_ame>
Status:	ASSIGNED ---
Severity:	normal	CC:	kdelibs-bugs-null, nate
Priority:	NOR
Version First Reported In:	5.28.0
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description taro yamada 2016-11-22 14:26:26 UTC

This is related to https://bugs.kde.org/show_bug.cgi?id=352927.
src/ioslaves/file/file.cpp has been fixed by using readlink instead of symlinkTarget(), but src/core/kfileitem.cpp still uses QFile::symLinkTarget().

For that reason, under certain circumstances, Dolphin's properties dialog will show the target of the symbolic link as an absolute path even though it is actually a relative path.

Is it ok to copy the same code as src/ioslaves/file/file.cpp?
Or how can it avoid duplication of code?


Thanks.

Comment 1 Nate Graham 2018-08-22 20:37:16 UTC

Yes, please go ahead. You can submit a patch if you'd like! See https://community.kde.org/Infrastructure/Phabricator

If there are issues with your approach, that's what code review is for :)