Summary: | OSD shows different sized icon depending on text | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | Martin Flöser <mgraesslin> |
Component: | general | Assignee: | David Edmundson <kde> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bhush94, bugseforuns, kde, notuxius, plasma-bugs, sotadic_restage |
Priority: | NOR | ||
Version: | master | ||
Target Milestone: | 1.0 | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/af31ad46c025c0e53de1427527876366fcd869a6 | Version Fixed In: | 5.20.0 |
Sentry Crash Report: | |||
Attachments: |
English Layout
German layout |
Created attachment 102323 [details]
German layout
I've seen a bug report about this before and I thought David even fixed it, but I can confirm. Also happens with text vs slider (e.g. muted vs non-muted audio) I thought I fixed the slider vs text ; my change wouldn't have had an impact on the different text though. Can confirm in: Distribution: KDE neon Developer Edition - Stable Branches Plasma: 5.11.3 Frameworks: 5.41.0 Qt: 5.9.2 Kernel 4.10.0-38-generic Type: 64-bit Also i notices that keyboard lang change notification appears only in Wayland. *** Bug 400088 has been marked as a duplicate of this bug. *** *** Bug 419551 has been marked as a duplicate of this bug. *** Git commit af31ad46c025c0e53de1427527876366fcd869a6 by Nate Graham, on behalf of Kai Uwe Broulik. Committed on 19/05/2020 at 20:03. Pushed by ngraham into branch 'master'. Use more compact OSD Summary: A frequent complaint over the years is the size of the OSD. It was tried to alleviate that by having it start fading out slowly immediately but the way it was done wasn't ideal, didn't work on Wayland, and also causes flickering issues in recent Qt versions. This changes the OSD to a bar-like design similar to the one used in Plasma 4. Related: bug 344393 FIXED-IN: 5.20.0 Depends on D29263 Test Plan: Various OSD messages {F6773939} It can grow, if necccessary, to accomodate translations, up to half the screen width. With Air theme {F6773940} Full desktop screenshot for some context {F6773941} Reviewers: #plasma, #vdg, broulik, niccolove, ndavis Reviewed By: #vdg, niccolove, ndavis Subscribers: ndavis, kori, Armstrong, alexde, achauvel, abetts, ngraham, davidedmundson, hein, Codezela, filipf, zzag, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D20569 M +20 -44 lookandfeel/contents/osd/OsdItem.qml https://invent.kde.org/plasma/plasma-workspace/commit/af31ad46c025c0e53de1427527876366fcd869a6 |
Created attachment 102322 [details] English Layout Steps to reproduce: 1. Use two keyboard layouts (e.g. English (US) and German) 2. Switch between the layouts Actual result: icon changes size when switching the layouts Expected result: Icon stays the same See the attached screenshots.