| Summary: | Edit Scheme Color Preview Not Working (black & white only) and No Update | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | David Rankin <drankinatty> |
| Component: | kcm_colors | Assignee: | Matthew Woehlke <mwoehlke.floss> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aspotashev, jpwhiting, olivier |
| Priority: | NOR | ||
| Version: | 5.8.3 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/plasma-desktop/1d05792ad782ce4cd41e31c1ab6eef3026b5218b | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: |
Edit Preview
General Dialog Preview |
||
Created attachment 102194 [details]
General Dialog Preview
General 'Application Color Scheme' dialog that does show static colors of current scheme on entry into kcm_color module
Confirmed on master. *** Bug 360606 has been marked as a duplicate of this bug. *** Git commit 1d05792ad782ce4cd41e31c1ab6eef3026b5218b by Martin Koller. Committed on 29/01/2017 at 14:44. Pushed by mkoller into branch 'master'. Fix some bugs (mem leak, layout, preview not showing colors) 1) memory leak when opening SchemeEditorDialog (is never deleted) 2) The color preview widget can be reduced in height to nearly zero, which makes no sense 3) The scheme editor does not reflect any color change in the preview widget 4) triple-redundant widgets in the scmeditorcolors.ui file 5) user unfriendly current tab when opening the SchemeEditorDialog (I want to change a color, so the color tab shall be active) 6) Unneeded and incorrect tab index enum (enum values were not corresponding to the index the tab was inserted) 7) The SchemeEditorDialog did not just only expand the color table when enlarging the dialogs height Related: bug 372309 REVIEW: 129902 M +1 -0 kcms/colors/colorscm.cpp M +0 -6 kcms/colors/colorsettings.ui M +18 -18 kcms/colors/preview.ui M +1 -0 kcms/colors/scmeditorcolors.cpp M +5 -141 kcms/colors/scmeditorcolors.ui M +6 -5 kcms/colors/scmeditordialog.cpp M +0 -7 kcms/colors/scmeditordialog.h M +0 -12 kcms/colors/scmeditordialog.ui https://commits.kde.org/plasma-desktop/1d05792ad782ce4cd41e31c1ab6eef3026b5218b |
Created attachment 102193 [details] Edit Preview System Settings > Appearance > Colors > Edit Scheme > [Colors tab] The color preview for the current scheme shown at the top of the dialog when the colors tab is selected does not reflect the current color scheme and does not respond to any changes to the color scheme. Of all the color scheme previews in KDE, this is the one that must work to aid the color scheme setting changes. Expected behavior - upon selecting the color tab the preview should reflect the current color scheme. Upon a change of a color setting, the preview should update to reflect the change. This does not happen. (in fact, it doesn't appear to work at all) The preview box shown on the general 'Application Color Scheme' dialog does at least have colors shown when you enter the 'Colors' part of System Settings, but it ignores any changes made during editing. On selection of 'Edit Scheme' > [Colors] tab, the preview box shown appears to have only 2 colors (gray and darker gray). (see screenshot 'Editing Preview') It does not reflect the colors for the current scheme being edited and it fails to shown any changes made to the scheme. (at first I though maybe it only displays 'changes' so I set all text to Red to test -- nope, it just doesn't display any color and does not work at all)