Bug 372207

Summary: kwrite file open dialog, filenames overwrite icons (probably all apps)
Product: [Frameworks and Libraries] frameworks-kio Reporter: David Rankin <drankinatty>
Component: generalAssignee: David Faure <faure>
Status: RESOLVED FIXED    
Severity: normal CC: arthur, jtamate, kdelibs-bugs-null, simonandric5
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: File open dialog showing filename overwriting file icon in dialog.

Description David Rankin 2016-11-08 09:25:16 UTC
Created attachment 102118 [details]
File open dialog showing filename overwriting file icon in dialog.

When using File -> Open, filenames with the .dat, .rdf (probably any binary file) the filename is not shown correctly, instead it is shown "On Top Of" the file icon itself. This should not happen. A screenshot is attached. Look at, e.g.:

localstore.rdf
mailViews.dat

for examples of the problem.
Comment 1 Christoph Feck 2016-11-09 00:35:03 UTC
It looks like Qt thinks these file types have no associated icon, and does not reserve any space for them. Then, something else thinks they should get a default icon anyway.
Comment 2 Christoph Feck 2017-06-10 10:15:12 UTC
*** Bug 381060 has been marked as a duplicate of this bug. ***
Comment 3 Christoph Feck 2017-09-04 15:17:16 UTC
https://phabricator.kde.org/D7318
Comment 4 Fabian Vogt 2017-09-19 11:42:07 UTC
Git commit 31361267d41977047e2523ae95718b20713d0d6d by Fabian Vogt.
Committed on 19/09/2017 at 11:41.
Pushed by fvogt into branch 'master'.

KFileItemDelegate: Always reserve space for icons

Summary:
Even null icons are drawn so also reserve space for them to avoid overlapping.

Test Plan: http://imgur.com/a/fG2T0

Reviewers: #frameworks

Subscribers: #frameworks

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D7318

M  +1    -4    src/widgets/kfileitemdelegate.cpp

https://commits.kde.org/kio/31361267d41977047e2523ae95718b20713d0d6d