Summary: | Cloning brush is not working | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | Nataly Novak <miss.novak137> |
Component: | Brush engines | Assignee: | Krita Bugs <krita-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | dimula73, freebox64 |
Priority: | NOR | ||
Version: | git master (please specify the git hash!) | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | Video example |
Description
Nataly Novak
2016-11-01 12:15:16 UTC
Created attachment 101944 [details]
Video example
Yes. Happens also with the "Freehand Brush Tool".
No issues with tablet, only mouse.
(Ubuntu 14.04 - Krita 3.0.91)
(sorry, the Clone tool is indeed a brush, of course :) It seems it doesn't happen when: ("Tool Options" docker) > "No smoothing", is selected. Besides, I wasn't aware of Bug 369547 , sorry. (I'm marking this as "resolved > fixed" for now... If you think yours is a different issue then please, feel free to reopen this report or let me know. Thanks! :) Actually, it happens with any smoothing option and both with the tablet and the mouse. So I'm reopenning the bug. Related to bug 369119. Instant preview is disabled for Instant Preview Git commit 8c5506fe319ab877343274fcd07c2c3266eaa681 by Dmitry Kazakov. Committed on 07/11/2016 at 12:22. Pushed by dkazakov into branch 'rempt/impex-refactoring'. Cold init Lod Availability widget when switching presets The problem is that we still store the semantics of the lod availability in the *widgets*, not in the settings object itself. One day it'll have to be refactored like we did for size, spacing and other options. Related: bug 369119 Fixes T4221 Ref T4250 M +2 -0 libs/ui/widgets/kis_paintop_presets_popup.cpp http://commits.kde.org/krita/8c5506fe319ab877343274fcd07c2c3266eaa681 Git commit 75144827d563efdbd5fa2b279894753e9e9c4207 by Dmitry Kazakov. Committed on 07/11/2016 at 14:42. Pushed by dkazakov into branch 'kazakov/try-port-clone-brush-lod'. The first try to port Clone Brush into LoD system It almost works, except that when the user does overlapping self copying strokes (bitBltOldData). That is in this part: { KisPainter copyPainter(m_srcdev); copyPainter.setCompositeOp(COMPOSITE_COPY); copyPainter.bitBltOldData(0, 0, realSourceDevice, srcPoint.x(), srcPoint.y(), sw, sh); copyPainter.end(); } Looks like the transaction for the projection is not started or somehow cleared. M +2 -0 libs/image/kis_clone_layer.cpp M +1 -1 libs/image/kis_indirect_painting_support.cpp M +1 -1 libs/image/kis_indirect_painting_support.h M +7 -0 libs/image/kis_layer.cc M +2 -0 libs/image/kis_layer.h M +7 -0 libs/image/kis_paint_layer.cc M +2 -0 libs/image/kis_paint_layer.h M +3 -0 libs/image/kis_selection_based_layer.cpp M +7 -2 plugins/paintops/defaultpaintops/duplicate/kis_duplicateop.cpp M +1 -1 plugins/paintops/defaultpaintops/duplicate/kis_duplicateop_settings_widget.cpp http://commits.kde.org/krita/75144827d563efdbd5fa2b279894753e9e9c4207 Git commit 72ac1393994b0bae8b3154d3ddd08d950a05636a by Dmitry Kazakov. Committed on 07/11/2016 at 15:16. Pushed by dkazakov into branch 'krita/3.1'. Cold init Lod Availability widget when switching presets The problem is that we still store the semantics of the lod availability in the *widgets*, not in the settings object itself. One day it'll have to be refactored like we did for size, spacing and other options. Related: bug 369119 Fixes T4221 Ref T4250 M +2 -0 libs/ui/widgets/kis_paintop_presets_popup.cpp http://commits.kde.org/krita/72ac1393994b0bae8b3154d3ddd08d950a05636a The bug is now fixed: clone brush doesn't support LoD. Ideally, it should, but there is some weird problem with projections, which I cannot solve atm. |