Bug 371411

Summary:	Unify fstat64/fstatat64 wrappers
Product:	[Developer tools] valgrind	Reporter:	Marcin Juszkiewicz <marcin>
Component:	general	Assignee:	Julian Seward <jseward>
Status:	RESOLVED NOT A BUG
Severity:	normal	CC:	ivosh
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	patch move all stat64 to generic Handle (int flags) argument of fstatat64 on arm and ppc32

Description Marcin Juszkiewicz 2016-10-21 13:46:49 UTC

arm/mips32/ppc32/x86 have similar wrappers for those two syscalls.

arm/mips32 ones do not handled 4th arguments (int flags) of syscall.

Not tested.

Reproducible: Always

Comment 1 Marcin Juszkiewicz 2016-10-21 13:47:26 UTC

Created attachment 101680 [details]
patch

Comment 2 Marcin Juszkiewicz 2016-10-21 13:56:08 UTC

Created attachment 101681 [details]
move all *stat*64 to generic

this patch adds stat64 and lstat64

Comment 3 Marcin Juszkiewicz 2016-10-21 14:26:43 UTC

should check first with build. stat structure differ per arch ;(

Comment 4 Marcin Juszkiewicz 2016-10-21 14:37:57 UTC

Created attachment 101683 [details]
Handle (int flags) argument of fstatat64 on arm and ppc32

x86 and mips32 have wrappers which support all 4 arguments. So let arm and ppc32 join them.

Comment 5 Ivo Raisr 2017-05-05 15:35:44 UTC

Marcin, please double check with the actual arm and ppc32 kernel and glibc that these syscalls really take the 4th argument (flags).
Perhaps they use oabi-compat?

Comment 6 Marcin Juszkiewicz 2021-10-04 09:04:57 UTC

I forgot how I wanted to rewrite it.