Summary: | kdenlive_render crashes every render | ||
---|---|---|---|
Product: | [Applications] kdenlive | Reporter: | Peter <Peter> |
Component: | Video Display & Export | Assignee: | Jean-Baptiste Mardelle <jb> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | kensington, Peter |
Priority: | NOR | ||
Version: | 16.08.2 | ||
Target Milestone: | --- | ||
Platform: | Neon | ||
OS: | Linux | ||
See Also: |
https://bugs.kde.org/show_bug.cgi?id=371478 https://bugs.kde.org/show_bug.cgi?id=371263 |
||
Latest Commit: | Version Fixed In: | ||
Attachments: | Patch to fix segfault and respect kdenlive_render help text |
Description
Peter
2016-10-19 18:24:57 UTC
Removing the following from kdenlive-16.08.2/renderer/renderjob.cpp makes it not crash.
> // Decode url
> QString url = QUrl::fromEncoded(args.takeLast().toUtf8()).path();
> args << url;
Problem also present in git head.
Created attachment 102139 [details]
Patch to fix segfault and respect kdenlive_render help text
Hi, this was segfaulting pretty much everytime due to args.takeLast() not finding anything, but also didn't really do what the kdenlive_render help text describes "player" field as doing ("player: path to video player to play when rendering is over, use '-' to disable playing").
Admittedly, the patch accepts path or just the program name.
Anyway, now it will ignore "-" as described and will control what player is used when provided. If this issue is why player was removed from kdenlive, I suppose it could be added back in?
Also probably fixes at least #371487 & #371263.
Sorry, I meant: https://bugs.kde.org/show_bug.cgi?id=371478 and https://bugs.kde.org/show_bug.cgi?id=371263 Even just && m_player != "-" alone would mean "generate script" scripts wouldn't try to play anything and segfault because of not enough arguments as generate script uses "-" as the player for kdenlive_render - this is how I render all my files. |