| Summary: | Zoom function doesn't work properly on HiDPI Display | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | younker.dl@gmail.com <younky.yang> |
| Component: | Preview-Image | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles |
| Priority: | NOR | ||
| Version: | 5.2.0 | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/kde/digikam/commit/4c8c1f998d03064fc5e92a9d0214394965f52cb5 | Version Fixed In: | 6.2.0 |
| Sentry Crash Report: | |||
|
Description
younker.dl@gmail.com
2016-10-17 15:15:55 UTC
Just tried xnviewmp. And it shows the image correct, just behave like on others platforms. So this is an issue of our code implementation. I tried to learn QT programming and just tested with QGraphicView, it does show the image based on the scale_factor settings which is not right based on my experience on other platforms. So this may be a Qt bug. but can we do something on our codes to make the behaviour better? If i remember, there is already code relevant in DK to fix this problem. And this Qt problem can be fixed with last 5.7. I'm not sure. Look this entry : https://bugs.kde.org/show_bug.cgi?id=337231 ... and all patches applied to DK source code. Gilles Caulier I tried on Windows with a sample code to show a picture through QGraphicsView, it works on Windows perfect, but not on Linux. I think this is the issue of Qt. It is not fixed on Linux at all Can you reproduce the problem using digiKam Linux AppImage bundle ? The last bundle is available at this url: https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM Gilles Caulier (In reply to caulier.gilles from comment #5) > Can you reproduce the problem using digiKam Linux AppImage bundle ? The last > bundle is available at this url: > > https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM > > Gilles Caulier I didn't use the appbundle of digikam. But from my digikam and gwenview on my gentoo box, the behaviou is same. What I expect is to have the image displayed in 1:1 pixel mapping no matter the zoom rate I selected for HiDPI display. That will make the image really sharp. You must take a try of current AppImage bundle of 6.0.0 pre-release where more than 300 files are now closed since last 5.9.0 stable release. The bundle is available here : https://files.kde.org/digikam/ Thanks inadvance Gilles Caulier gwenview will have fix for this in 19.04 release and thumbnail part will be fixed in 19.08. Is there any update for digikam? https://bugs.kde.org/show_bug.cgi?id=373178 Git commit cb6b0ef7519471b78e7cd04807af24b2f893e982 by Maik Qualmann. Committed on 03/05/2019 at 16:53. Pushed by mqualmann into branch 'master'. fix HiDPI problem under Linux # 1 - Preview - Light Table - Image Editor - Slideshow - Thumbnails not yet Related: bug 403197, bug 381128 M +4 -2 core/libs/widgets/graphicsview/graphicsdimgitem.cpp M +2 -1 core/utilities/imageeditor/widgets/imagepreviewitem.cpp M +2 -1 core/utilities/slideshow/slideimage.cpp https://invent.kde.org/kde/digikam/commit/cb6b0ef7519471b78e7cd04807af24b2f893e982 Git commit 4c8c1f998d03064fc5e92a9d0214394965f52cb5 by Maik Qualmann. Committed on 05/05/2019 at 07:57. Pushed by mqualmann into branch 'master'. fix zoom image on HiDPI display Related: bug 403197, bug 381128 FIXED-IN: 6.2.0 M +2 -1 NEWS M +4 -0 core/dplugins/generic/view/glviewer/glviewertexture.cpp M +2 -2 core/libs/widgets/graphicsview/graphicsdimgitem.cpp M +18 -14 core/libs/widgets/graphicsview/imagezoomsettings.cpp M +2 -1 core/libs/widgets/graphicsview/imagezoomsettings.h M +2 -2 core/utilities/imageeditor/widgets/imagepreviewitem.cpp https://invent.kde.org/kde/digikam/commit/4c8c1f998d03064fc5e92a9d0214394965f52cb5 |