| Summary: | bug in FindFFmpeg.cmake | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kfilemetadata | Reporter: | RJVB <rjvbertin> |
| Component: | general | Assignee: | Pinak Ahuja <pinak.ahuja> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | a.stippich, rdieter |
| Priority: | NOR | ||
| Version First Reported In: | 5.27.0 | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | All | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
This is fixed with the current version of KFileMetaData, it was probably forgotten to close this bug. Fixed in the *current* version, over 20 releases later? Wow, that redefines certain concepts... And no, I didn't forget to close the ticket. I completely forgot it was there - and since I've long stopped having the time to follow each point release of the crazy KF5 cycle it would still be a while before I discovered that my patch no longer applied. I should have been more precise. I just went over some of the bug reports in KFileMetaData in order to clean them up a little bit. I looked at your patch and noticed that the changes are already in. So I really don't know who did it or when that fix was made, but it's there. Ironic, https://cgit.kde.org/kfilemetadata.git/commit/cmake/FindFFmpeg.cmake?id=ce597d98de24d5456e7e05c0306a0498a5826723 commit by RJVB Indeed - didn't I imply something about my memory ;) |
There's a typo causing a bug in FindFFmpeg.cmake that causes it to consider libpostproc "not found" even if it's installed. Reproducible: Always Steps to Reproduce: configure kfilemetadata with a compatible FFMpeg installed Actual Results: libpostproc is considered not available Expected Results: all installed FFMpeg components should be found --- cmake/orig.FindFFmpeg.cmake 2016-10-11 21:21:21.000000000 +0200 +++ cmake/FindFFmpeg.cmake 2016-10-11 21:49:52.000000000 +0200 @@ -124,7 +126,7 @@ find_component(AVDEVICE libavdevice avdevice libavdevice/avdevice.h) find_component(AVUTIL libavutil avutil libavutil/avutil.h) find_component(SWSCALE libswscale swscale libswscale/swscale.h) - find_component(POSTPROC libpostproc postproc libpostproc/postprocess.h) + find_component(POSTPROCESS libpostproc postproc libpostproc/postprocess.h) # Check if the required components were found and add their stuff to the FFMPEG_* vars. foreach (_component ${FFmpeg_FIND_COMPONENTS})