| Summary: | activitymanager/ActivityItem.qml:77: ReferenceError: size is not defined | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Elias Probst <mail> |
| Component: | Activity Switcher sidebar | Assignee: | Ivan Čukić <ivan.cukic> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kde, notmart, plasma-bugs-null |
| Priority: | NOR | ||
| Version First Reported In: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/plasma-desktop/3d11772044470154530e41dd1cfb35031344ea4f | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Elias Probst
2016-10-03 11:29:56 UTC
It is a bug, but I don't think it's causing your lack of thumbnail, the code for the image providers handles the case of there being no source size and returns something arbitrary (which is the correct behaviour in that case) the lack of thumbnail should be adressed at the latest thumbnail generation refactor, this is a separate issue. Git commit 7cbcf46b332ef9c22306c5a628444cd81d0222b5 by Marco Martin. Committed on 03/10/2016 at 14:33. Pushed by mart into branch 'master'. Image has width and height properties, not "size" Summary: this makes it actually do what it was intended to, set the source size to the actual thumbnail size to keep a scaled down texture in menory Test Plan: normal usage, seems to work as expected, no warning Reviewers: #plasma, sebas, davidedmundson Reviewed By: #plasma, sebas, davidedmundson Subscribers: davidedmundson, broulik, apol, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D2919 M +1 -1 desktoppackage/contents/activitymanager/ActivityItem.qml http://commits.kde.org/plasma-desktop/7cbcf46b332ef9c22306c5a628444cd81d0222b5 Git commit 3d11772044470154530e41dd1cfb35031344ea4f by Marco Martin. Committed on 03/10/2016 at 14:34. Pushed by mart into branch 'Plasma/5.8'. Image has width and height properties, not "size" Summary: this makes it actually do what it was intended to, set the source size to the actual thumbnail size to keep a scaled down texture in menory Test Plan: normal usage, seems to work as expected, no warning Reviewers: #plasma, sebas, davidedmundson Reviewed By: #plasma, sebas, davidedmundson Subscribers: davidedmundson, broulik, apol, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D2919 M +1 -1 desktoppackage/contents/activitymanager/ActivityItem.qml http://commits.kde.org/plasma-desktop/3d11772044470154530e41dd1cfb35031344ea4f |