Bug 368832

Summary: New Pim Events Plugin renders inacurate output for CalDAV calendar
Product: [Plasma] plasmashell Reporter: PK <pieterkristensen>
Component: Digital ClockAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: ayazcw, bugrprt21882, bymask, dutchgigalo, dvratil, kde, pradhanphy, wulf.richartz
Priority: NOR    
Version: 5.7.5   
Target Milestone: 1.0   
Platform: Neon   
OS: Linux   
Latest Commit: http://commits.kde.org/kdepim-addons/c921a14e0a30e13342e94cce74d4ad1bbb3a64c5 Version Fixed In: 5.3.3
Sentry Crash Report:

Description PK 2016-09-15 06:03:29 UTC 
In Korganizer I have one account configured that contains five agenda's. I was very happy to see that the Pim Events Plugin was launched in plasma 5. 
Only it gives very inaccurate output. When I change something in Korganizer in one agenda, THEN that agenda is rendered by the Pim Events Plugin, but all other agenda's aren't. 
After a reboot even this agenda is not shown. Until I change something in it again.
Strange thing is that is makes no difference to re-read or restart Korganizer. 

Reproducible: Always

Steps to Reproduce:
1. setup a CalDAV calendar in Korganizer
2. activate it in Pim Events Plugin
3. reboot (or perhaps start plasmashell again)

Actual Results:  
The Pim Events Plugin shows NO events

Expected Results:  
The Pim Events Plugin should follow Korganizer faithfully and accurately.
Comment 1 PK 2016-09-15 06:06:03 UTC 
I must perhaps add that it is a Gmail calendar. I find Korganizer very reliable when I read that as CalDAV.
Comment 2 Kai Uwe Broulik 2016-09-15 07:43:17 UTC 
CC'ing Dan as kdepim maintainer
Comment 3 PK 2016-10-12 19:48:51 UTC 
I just installed plasma 5.8.1 and the pim events plugin seems to show a little more results suddenly. I would not at all call it dependable but perhaps it is a slight progression.
Comment 4 Daniel Vrátil 2016-10-14 00:05:23 UTC 
Git commit c921a14e0a30e13342e94cce74d4ad1bbb3a64c5 by Daniel Vrátil.
Committed on 14/10/2016 at 00:04.
Pushed by dvratil into branch 'Applications/16.08'.

PimEventsPlugin: switch from ETMCalendar to custom EventModel

It is hard to tame the ETMCalendar to list only the right events
and listen only to the right changes while not keeping everything
loaded in the memory all the time.

The EventModel is a lightweight bridge between Akonadi and the
CalendarBase. It inserts and removes data from the CalendarBase
based on currently enabled collections and handles updates.
This solves various issues with populating the model initially,
listening to the correct changes and it also reduces memory usage
by not keeping events from disabled calendars in memory.
Related: bug 369606
FIXED-IN: 5.3.3

M  +1    -0    plugins/plasma/pimeventsplugin/CMakeLists.txt
M  +27   -34   plugins/plasma/pimeventsplugin/akonadipimdatasource.cpp
M  +2    -7    plugins/plasma/pimeventsplugin/akonadipimdatasource.h
M  +1    -1    plugins/plasma/pimeventsplugin/autotests/CMakeLists.txt
A  +178  -0    plugins/plasma/pimeventsplugin/eventmodel.cpp     [License: GPL (v2+)]
C  +29   -20   plugins/plasma/pimeventsplugin/eventmodel.h [from: plugins/plasma/pimeventsplugin/akonadipimdatasource.h - 051% similarity]
M  +3    -3    plugins/plasma/pimeventsplugin/pimcalendarsmodel.cpp
M  +1    -1    plugins/plasma/pimeventsplugin/pimeventsplugin.h

http://commits.kde.org/kdepim-addons/c921a14e0a30e13342e94cce74d4ad1bbb3a64c5
Comment 5 PK 2016-10-16 16:36:16 UTC 
Fixed-in: 5.3.3 is great news! Thank you for your great work!
Just out of curiousity: what application has this release number 5.3.3? Will it take long to be ready for "general consuption"?
Comment 6 Wulf 2016-10-31 23:11:18 UTC 
I had these problems too; after a necessary KDE Config reset it works now for me with these settings

I have two calendar accounts: "owncloud" and "Birthdays & Anniversaries"

korganizer:
settings: Time and Date, Holidays: set to (bavaria for me)
shown caledars: owncloud/"standard" and "Birthdays & Anniversaries"
not shown: owncloud/contact birthdays

digital clock:
calendar: all = holidays and PIM events
holidays: none
PIM events Plugin chosen: "Birthdays & Anniversaries" ans owncloud/"standard"
PIM events Plugin not chosen: owncloud/contact birthdays and search

result: I can see all in my digital clock:
- holidays (which seems to depend from regional language setting in systemsettings, because with american english as language, digital clock shows Columbus Day as holiday but korganizer shows correctly "Allerheiligen"?!?)
- Birthdays of my contacts
- and of course events of my Standard Owncloud calendar
Comment 7 PK 2016-11-01 06:55:02 UTC 
Great Wulf!
I had that too, one or two times. Only on my systems it never survived a reboot of the system.
Comment 8 Wulf 2016-11-01 08:37:50 UTC 
No problem here with reboot/relogin; but I got a plasma update from 5.8.1 to 5.8.2 (Arch) on 20161018 - I don't know wether this is the reason
Comment 9 PK 2016-11-23 19:30:41 UTC 
Today I recieved plasma 5.8.4 on my Neon KDE box. The problem is 100% fixed! And btw.: speaking about an elegant ui!
Thanks!
Comment 10 Daniel Vrátil 2017-01-06 22:05:55 UTC 
*** Bug 368161 has been marked as a duplicate of this bug. ***
Comment 11 Daniel Vrátil 2017-01-06 22:10:10 UTC 
*** Bug 372914 has been marked as a duplicate of this bug. ***
Comment 12 Daniel Vrátil 2017-01-06 22:10:39 UTC 
*** Bug 373143 has been marked as a duplicate of this bug. ***
Comment 13 David Edmundson 2017-01-20 04:12:11 UTC 
*** Bug 375310 has been marked as a duplicate of this bug. ***
Comment 14 Marco Martin 2017-01-30 12:42:56 UTC 
*** Bug 375592 has been marked as a duplicate of this bug. ***