| Summary: | Add audio -> "Bitrate" column to Details view mode | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | KDE Neon user <emailmeat> |
| Component: | view-engine: details mode | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | bugseforuns, nate |
| Priority: | NOR | ||
| Version: | 17.04.2 | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/dolphin/76698ff82cf5e88c1ea2e0686ce7450cf558af97 | Version Fixed In: | |
|
Description
KDE Neon user
2016-09-07 19:22:45 UTC
The appropriate string in kbalooroledprovider.cpp is bitRate. This works using the expected diff, but the column will express the bitrate using an integer ("193000") instead of a more nicely-formatted string like "193.0 kB/s". Take a look at KBalooRolesProvider::durationFromValue() at the bottom of the file for an idea of how to format the string nicely.
Submitted a patch: https://phabricator.kde.org/D7763 Git commit 76698ff82cf5e88c1ea2e0686ce7450cf558af97 by Nate Graham.
Committed on 22/09/2017 at 04:56.
Pushed by ngraham into branch 'master'.
Add Bitrate to Dolphin's Additional Information
Summary:
Adds Bitrate to Dolphin's Additional information columns.
Test Plan:
Tested in KDE Neon. A bitrate column can be added and shows the bitrate in kb/s:
{F3907210}
Works for audio as well as video files!
Reviewers: #dolphin, #kde_applications, broulik, aacid, dfaure, emmanuelp
Reviewed By: #dolphin, #kde_applications, emmanuelp
Subscribers: rkflx, alexeymin, anthonyfieroni
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D7763
M +1 -0 src/kitemviews/kfileitemmodel.cpp
M +1 -1 src/kitemviews/kfileitemmodel.h
M +13 -0 src/kitemviews/private/kbaloorolesprovider.cpp
M +6 -0 src/kitemviews/private/kbaloorolesprovider.h
https://commits.kde.org/dolphin/76698ff82cf5e88c1ea2e0686ce7450cf558af97
|