Summary: | Color schemes collide with the ones from Plasma's breeze | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | Heiko Becker <heiko.becker> |
Component: | General | Assignee: | Krita Bugs <krita-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | halla, kensington |
Priority: | NOR | ||
Version: | git master (please specify the git hash!) | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/krita/f50c5949365e333e9762b635722251a8406b3f81 | Version Fixed In: |
Description
Heiko Becker
2016-09-01 09:21:01 UTC
But isn't the location where we store the color schemes completely independent from the one plasma uses? And Krita doesn't look at the location where plasma stores the color schemes. (In reply to Boudewijn Rempt from comment #1) > But isn't the location where we store the color schemes completely > independent from the one plasma uses? No, it might be independent in theory, but the relevant cmake files default to the same location. krita (krita/data/themes/CMakeLists.txt): install( ... BreezeDark.colors BreezeHighContrast.colors ... ${schemefiles} DESTINATION ${DATA_INSTALL_DIR}/color-schemes breeze (CMakeLists.txt): INSTALL(FILES colors/BreezeDark.colors DESTINATION ${DATA_INSTALL_DIR}/color-schemes/) INSTALL(FILES colors/BreezeHighContrast.colors DESTINATION ${DATA_INSTALL_DIR}/color-schemes/) Ah, you're right. I'll fix that... Git commit f50c5949365e333e9762b635722251a8406b3f81 by Boudewijn Rempt. Committed on 24/10/2016 at 11:48. Pushed by rempt into branch 'master'. When Krita is built by distributions for installation into /usr, the breeze themes we borrowed shouldn't be installed, because all color themes share the same installation directory. But when we build for Windows, OSX or AppImages, we do want to have these styles available because they're very nice. M +2 -0 CMakeLists.txt M +9 -3 krita/data/themes/CMakeLists.txt http://commits.kde.org/krita/f50c5949365e333e9762b635722251a8406b3f81 |