Bug 367938

Summary: Wrong icon with Network Manager 1.4.0
Product: [Plasma] plasma-nm Reporter: Elvis Angelaccio <elvis.angelaccio>
Component: appletAssignee: Jan Grulich <jgrulich>
Status: RESOLVED UPSTREAM    
Severity: normal CC: archmango, demm, igor.poboiko, jgrulich, kalinda, kde, lukas, marius.steffen, metamesa, ongun.kanat, stupor_scurvy343
Priority: NOR    
Version: 5.7.3   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: Screenshot with the wrong icon.
dbus-monitor --system "type='signal',sender='org.freedesktop.NetworkManager'"
Connection Editor - Duplicate Entries
Plasmashell startup log

Description Elvis Angelaccio 2016-08-28 20:54:20 UTC
I recently upgraded to Network Manager 1.4.0 and it looks like the default "connected" icon is gone. Instead I have a greyed icon with a question mark (see attachment).

But the network is connected and working as expected, so it's only an icon problem.

Reproducible: Always
Comment 1 Elvis Angelaccio 2016-08-28 20:54:54 UTC
Created attachment 100833 [details]
Screenshot with the wrong icon.
Comment 2 Jan Grulich 2016-08-29 07:29:51 UTC
What's the output from:

1) qdbus --system --literal org.freedesktop.NetworkManager /org/freedesktop/NetworkManager org.freedesktop.NetworkManager.PrimaryConnection
2) qdbus --system org.freedesktop.NetworkManager /org/freedesktop/NetworkManager org.freedesktop.NetworkManager.PrimaryConnectionType
Comment 3 Elvis Angelaccio 2016-08-29 08:06:24 UTC
(In reply to Jan Grulich from comment #2)
> What's the output from:
> 
> 1) qdbus --system --literal org.freedesktop.NetworkManager
> /org/freedesktop/NetworkManager
> org.freedesktop.NetworkManager.PrimaryConnection

[Variant: [ObjectPath: /org/freedesktop/NetworkManager/ActiveConnection/1]]

> 2) qdbus --system org.freedesktop.NetworkManager
> /org/freedesktop/NetworkManager
> org.freedesktop.NetworkManager.PrimaryConnectionType

802-11-wireless
Comment 4 Jan Grulich 2016-08-29 10:22:47 UTC
Please provide also information described here:
https://techbase.kde.org/Projects/Solid/Plasma-nm#My_connection_in_the_applet_shows_wrong_information
Comment 5 Elvis Angelaccio 2016-08-29 10:53:19 UTC
Created attachment 100838 [details]
dbus-monitor --system "type='signal',sender='org.freedesktop.NetworkManager'"

I noticed that a "killall plasmashell; plasmashell" fixes the icon (I attached the output of dbus-monitor while I kill plasma).

However, if I logout and log back in in Plasma, I get again the wrong icon. I can reproduce this every time.
Comment 6 Holly 2016-08-30 02:24:19 UTC
I can confirm I have this same bug and that the workaround of killing plasmashell and running it again without logging out fixes it.

I'm also running Arch Linux and I've got Plasma-nm 5.7.3 installed as well.
Comment 7 Holly 2016-08-30 02:26:30 UTC
Oh, also, I want to add that, for me at least, it isn't just the icon that's broken but also the list of wifi networks that comes up when clicking on it. If it's showing the wrong icon, then the list treats it like it isn't connected to any wifi networks even though hovering over the icon (like in the OP's screenshot) and looking in settings shows it is.
Comment 8 Mango 2016-08-30 13:17:59 UTC
Created attachment 100850 [details]
Connection Editor - Duplicate Entries
Comment 9 Mango 2016-08-30 13:18:48 UTC
Created attachment 100851 [details]
Plasmashell startup log
Comment 10 Mango 2016-08-30 13:19:36 UTC
I can also confirm that I have contracted the same bug in the last couple of days. As Holly mentions, it does not just affect the icon but also the list of available connections - although I am connected to a wifi network (evident from hovering over the icon), the connection list seems to think I'm not. It gives me no option to disconnect from my current network, however, I can connect to the same network again. If I do so, it prompts me for my password (again) and creates a new / duplicate entry in the connection editor - see screenshot "Connection Editor - Duplicate Entries".

After killing and restarting plasmashell, both icon and network list display correctly, and no duplicate entries are created, until reboot. I am also running plasma-nm 5.7.3-1 on arch linux and this is reproducable every time. Plasmashell startup log also attached.
Comment 11 marius.steffen 2016-08-30 19:52:21 UTC
I've got the the same bug as Holly and Mango. This bug is also triggered when disabling then enabling WiFi via my notebooks built-in button. Additionally, the "WiFi activated"-checkbox is still unchecked after re-enabling WiFi. I'm using ArchLinux, everything up-to-date.
Comment 12 Jan Grulich 2016-08-31 08:16:40 UTC
I found a bug or change in NM causing this issue:

Upstream report:
https://bugzilla.gnome.org/show_bug.cgi?id=770629
Comment 13 Ongun Kanat 2016-09-04 22:23:46 UTC
Bug still exists in 5.7.4 version.
Comment 14 Jan Grulich 2016-09-06 09:00:10 UTC
A solution for those who don't want to wait for upstream fix:
https://git.reviewboard.kde.org/r/128843/
Comment 15 Jan Grulich 2016-09-06 14:17:01 UTC
Git commit 7671424efb02e7194a18a4913da16bc2044a4cb9 by Jan Grulich.
Committed on 06/09/2016 at 14:16.
Pushed by grulich into branch 'master'.

Use standard o.f.DBus.Properties interface for PropertiesChanged signal for NM 1.4.0+
REVIEW:128843

M  +13   -0    src/accesspoint.cpp
M  +1    -0    src/accesspoint_p.h
M  +20   -2    src/activeconnection.cpp
M  +3    -1    src/activeconnection_p.h
M  +5    -0    src/adsldevice.cpp
M  +5    -0    src/bluetoothdevice.cpp
M  +5    -0    src/bonddevice.cpp
M  +5    -0    src/bridgedevice.cpp
M  +13   -0    src/connection.cpp
M  +1    -0    src/connection_p.h
M  +9    -0    src/device.cpp
M  +1    -0    src/device_p.h
M  +13   -1    src/dhcp4config.cpp
M  +1    -0    src/dhcp4config_p.h
M  +14   -1    src/dhcp6config.cpp
M  +1    -0    src/dhcp6config_p.h
M  +5    -0    src/genericdevice.cpp
M  +5    -0    src/gredevice.cpp
M  +5    -0    src/infinibanddevice.cpp
M  +5    -0    src/macvlandevice.cpp
M  +13   -1    src/manager.cpp
M  +1    -0    src/manager_p.h
M  +10   -0    src/modemdevice.cpp
M  +5    -0    src/olpcmeshdevice.cpp
M  +13   -0    src/settings.cpp
M  +1    -0    src/settings_p.h
M  +5    -0    src/teamdevice.cpp
M  +5    -0    src/tundevice.cpp
M  +5    -0    src/vethdevice.cpp
M  +5    -0    src/vlandevice.cpp
M  +16   -0    src/vpnconnection.cpp
M  +1    -0    src/vpnconnection_p.h
M  +5    -0    src/wimaxdevice.cpp
M  +5    -0    src/wireddevice.cpp
M  +5    -0    src/wirelessdevice.cpp

http://commits.kde.org/networkmanager-qt/7671424efb02e7194a18a4913da16bc2044a4cb9
Comment 16 Jan Grulich 2016-09-06 14:18:00 UTC
Fixed in upstream, but also "workarounded" in networkmanager-qt framework.
Comment 17 Mango 2016-09-06 19:12:01 UTC
Thanks, Jan! I can confirm that version 5.7.4 has resolved the issue for me (following a reboot).
Comment 18 Igor Poboiko 2016-09-19 08:09:22 UTC
*** Bug 368990 has been marked as a duplicate of this bug. ***